-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: updated building docs for windows #49767
doc: updated building docs for windows #49767
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
@nodejs/platform-windows @nodejs/build |
FYI @nodejs/platform-windows-arm Do these changes look good to you? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestions based on https://github.com/nodejs/node/pull/49051/files
Co-authored-by: Michaël Zasso <targos@protonmail.com>
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
775caf0
to
524159a
Compare
This comment has been minimized.
This comment has been minimized.
Can someone reapprove the PR? Apparently node land is failing due last commit not having an approval |
Landed in 47b2883 |
PR-URL: nodejs#49767 Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
PR-URL: #49767 Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
PR-URL: nodejs#49767 Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
This PR updates the Windows Building Instructions and the Boxstarter Automated Installation Script due to the following:
vcbuild.bat
will require Python3 to be installed, but on Windows, if Python 2 is installed, it will take precedence over the$PATH
; also, Python2 is not needed for Node.js builds anymore.