Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: replace forEach with for..of in test-http-perf_hooks.js #49818

Closed
wants to merge 2 commits into from
Closed

test: replace forEach with for..of in test-http-perf_hooks.js #49818

wants to merge 2 commits into from

Conversation

niyashiyas
Copy link
Contributor

Replaced forEach with for..of in test-http-perf_hooks.js

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Sep 23, 2023
@tniessen tniessen added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Sep 23, 2023
@niyashiyas
Copy link
Contributor Author

Made required changes. Please review it again.

@niyashiyas niyashiyas changed the title test: Replaced forEach with for..of in test-http-perf_hooks.js test: replace forEach with for..of in test-http-perf_hooks.js Sep 30, 2023
@lpinca lpinca added request-ci Add this label to start a Jenkins CI on a PR. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Oct 18, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 18, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54972/

This was referenced Oct 19, 2023
Open
Open
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55079/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55086/

lpinca pushed a commit that referenced this pull request Oct 21, 2023
@niyashiyas @lpinca
test: replace forEach with for..of in test-http-perf_hooks.js
4f0a7ae 
PR-URL: #49818
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@lpinca
Copy link
Member

lpinca commented Oct 21, 2023

Landed in 4f0a7ae.

@lpinca lpinca closed this Oct 21, 2023
This was referenced Oct 22, 2023
Open
Open
targos pushed a commit that referenced this pull request Oct 23, 2023
@niyashiyas @targos
test: replace forEach with for..of in test-http-perf_hooks.js
4d390e2 
PR-URL: #49818
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@targos targos mentioned this pull request Oct 23, 2023
Merged
@github-actions github-actions bot mentioned this pull request Oct 24, 2023
Open
27 tasks
alexfernandez pushed a commit to alexfernandez/node that referenced this pull request Nov 1, 2023
@niyashiyas @alexfernandez
test: replace forEach with for..of in test-http-perf_hooks.js
0b76ebc 
PR-URL: nodejs#49818
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit that referenced this pull request Nov 11, 2023
@niyashiyas @targos
test: replace forEach with for..of in test-http-perf_hooks.js
72626f9 
PR-URL: #49818
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@targos targos mentioned this pull request Nov 12, 2023
Merged
targos pushed a commit that referenced this pull request Nov 27, 2023
@niyashiyas @targos
test: replace forEach with for..of in test-http-perf_hooks.js
7f39f8e 
PR-URL: #49818
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@targos targos mentioned this pull request Nov 28, 2023
Merged
@juanarbol juanarbol mentioned this pull request Dec 6, 2023
Merged
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
test: replace forEach with for..of in test-http-perf_hooks.js
0111e13 
PR-URL: nodejs/node#49818
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
test: replace forEach with for..of in test-http-perf_hooks.js
21866f5 
PR-URL: nodejs/node#49818
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tniessen tniessen tniessen left review comments

@aduh95 aduh95 aduh95 approved these changes

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@niyashiyas @nodejs-github-bot @lpinca @tniessen @aduh95