Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: replace forEach with for..of in test-process-env-ignore #49825

Merged
merged 3 commits into from
Oct 7, 2023
Merged

test: replace forEach with for..of in test-process-env-ignore #49825

merged 3 commits into from
Oct 7, 2023

Conversation

niyashiyas
Copy link
Contributor

Replaced forEach with for..of in test-process-env-ignore-getter-setter.js

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Sep 23, 2023
@tniessen tniessen added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Sep 23, 2023
@niyashiyas niyashiyas changed the title test: Replaced forEach with for..of in test-process-env-ignore-getter… test: replace forEach with for..of in test-process-env-ignore Sep 30, 2023
@lpinca lpinca added commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. request-ci Add this label to start a Jenkins CI on a PR. labels Oct 6, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 6, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54587/

@github-actions github-actions bot mentioned this pull request Oct 7, 2023
Open
19 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54597/

@lpinca lpinca added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 7, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 7, 2023
@nodejs-github-bot nodejs-github-bot merged commit fce8fba into nodejs:main Oct 7, 2023
37 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in fce8fba

This was referenced Oct 8, 2023
Open
Open
@RafaelGSS RafaelGSS mentioned this pull request Oct 9, 2023
Merged
This was referenced Oct 10, 2023
Open
Open
alexfernandez pushed a commit to alexfernandez/node that referenced this pull request Nov 1, 2023
@niyashiyas @alexfernandez
test: replace forEach with for..of in test-process-env
c3a627a 
PR-URL: nodejs#49825
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
targos pushed a commit that referenced this pull request Nov 11, 2023
@niyashiyas @targos
test: replace forEach with for..of in test-process-env
8dd895e 
PR-URL: #49825
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@targos targos mentioned this pull request Nov 12, 2023
Merged
@juanarbol juanarbol mentioned this pull request Dec 6, 2023
Merged
debadree25 pushed a commit to debadree25/node that referenced this pull request Apr 15, 2024
@niyashiyas @debadree25
test: replace forEach with for..of in test-process-env
cf393e5 
PR-URL: nodejs#49825
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tniessen tniessen tniessen approved these changes

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@niyashiyas @nodejs-github-bot @lpinca @tniessen