Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: deflake test-perf-hooks.js #49892

Closed
wants to merge 1 commit into from
Closed

test: deflake test-perf-hooks.js #49892

wants to merge 1 commit into from

Commits on Sep 27, 2023

  1. test: deflake test-perf-hooks.js 

    Previously when checking the initial timing we did a lot of checks
after accessing and copying timing.duration and before we check
that timing.duration is roughly the same as performance.now(),
which can lead to flakes if the overhead of the checking is
big enough. Update the test to check timing.duration against
performance.now() as soon as possible when it's copied instead
of computed.
:#
    @joyeecheung
    joyeecheung committed Sep 27, 2023
    Configuration menu
    Copy the full SHA
    5cb6a53 View commit details
    Browse the repository at this point in the history