tls: use validateFunction for options.checkServerIdentity

[deokjinkim]

If user uses invalid type for options.checkServerIdentity in tls.connect(), it's not internal issue of Node.js. So validateFunction() is more proper than assert().

Fixes: #49839

Before

node:internal/assert:14
    throw new ERR_INTERNAL_ASSERTION(message);
    ^

Error [ERR_INTERNAL_ASSERTION]: This is caused by either a bug in Node.js or incorrect usage of Node.js internals.
Please open an issue with this stack trace at https://github.com/nodejs/node/issues

After

node:internal/validators:440
    throw new ERR_INVALID_ARG_TYPE(name, 'Function', value);
    ^

TypeError [ERR_INVALID_ARG_TYPE]: The "options.checkServerIdentity" property must be of type function. Received undefined

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/54323/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/54354/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/54359/

[nodejs-github-bot]

Commit Queue failed

- Loading data for nodejs/node/pull/49896
✔  Done loading data for nodejs/node/pull/49896
----------------------------------- PR info ------------------------------------
Title      tls: use validateFunction for `options.checkServerIdentity` (#49896)
Author     Deokjin Kim  (@deokjinkim)
Branch     deokjinkim:230927_use_validatefunction_for_checkserveridentity -> nodejs:main
Labels     tls, semver-major, author ready, needs-ci
Commits    2
 - tls: use validateFunction for `options.checkServerIdentity`
 - Update test/parallel/test-tls-basic-validations.js
Committers 2
 - Deokjin Kim 
 - GitHub 
PR-URL: https://github.com/nodejs/node/pull/49896
Fixes: https://github.com/nodejs/node/issues/49839
Reviewed-By: Antoine du Hamel 
Reviewed-By: Tobias Nießen 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/49896
Fixes: https://github.com/nodejs/node/issues/49839
Reviewed-By: Antoine du Hamel 
Reviewed-By: Tobias Nießen 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Wed, 27 Sep 2023 14:56:22 GMT
   ✔  Approvals: 2
   ✔  - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/49896#pullrequestreview-1648753553
   ✔  - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/49896#pullrequestreview-1648792270
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2023-09-29T10:45:06Z: https://ci.nodejs.org/job/node-test-pull-request/54359/
- Querying data for job/node-test-pull-request/54359/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  No git cherry-pick in progress
   ✔  No git am in progress
   ✔  No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
 * branch                  main       -> FETCH_HEAD
   0ee9c83ffc..e6e320ecc7  main       -> origin/main
✔  origin/main is now up-to-date
main is out of sync with origin/main. Mismatched commits:
 - 98518720a9 perf_hooks: reduce overhead of new resource timings
 - e6e320ecc7 perf_hooks: reduce overhead of new resource timings
--------------------------------------------------------------------------------
HEAD is now at e6e320ecc7 perf_hooks: reduce overhead of new resource timings
   ✔  Reset to origin/main
- Downloading patch for 49896
From https://github.com/nodejs/node
 * branch                  refs/pull/49896/merge -> FETCH_HEAD
✔  Fetched commits as e6e320ecc788..9ca4271b43ee
--------------------------------------------------------------------------------
[main db68c8dfe4] tls: use validateFunction for `options.checkServerIdentity`
 Author: Deokjin Kim 
 Date: Wed Sep 27 23:46:26 2023 +0900
 2 files changed, 10 insertions(+), 1 deletion(-)
[main a6418785ae] Update test/parallel/test-tls-basic-validations.js
 Author: Deokjin Kim 
 Date: Thu Sep 28 08:23:10 2023 +0900
 1 file changed, 3 insertions(+), 3 deletions(-)
   ✔  Patches applied
There are 2 commits in the PR. Attempting autorebase.
Rebasing (2/4)
Executing: git node land --amend --yes

⚠  Found Fixes: #49839, skipping..

--------------------------------- New Message ----------------------------------

tls: use validateFunction for options.checkServerIdentity
If user uses invalid type for options.checkServerIdentity

in tls.connect(), it's not internal issue of Node.js. So

validateFunction() is more proper than assert().
Fixes: #49839

PR-URL: #49896

Reviewed-By: Antoine du Hamel duhamelantoine1995@gmail.com

Reviewed-By: Tobias Nießen tniessen@tnie.de
[detached HEAD 74fe707cc8] tls: use validateFunction for options.checkServerIdentity

Author: Deokjin Kim deokjin81.kim@gmail.com

Date: Wed Sep 27 23:46:26 2023 +0900

2 files changed, 10 insertions(+), 1 deletion(-)

Rebasing (3/4)

Rebasing (4/4)
Executing: git node land --amend --yes

--------------------------------- New Message ----------------------------------

Update test/parallel/test-tls-basic-validations.js
Co-authored-by: Tobias Nießen tniessen@tnie.de

PR-URL: #49896

Fixes: #49839

Reviewed-By: Antoine du Hamel duhamelantoine1995@gmail.com

Reviewed-By: Tobias Nießen tniessen@tnie.de
[detached HEAD b55ae2a14e] Update test/parallel/test-tls-basic-validations.js

Author: Deokjin Kim deokjin81.kim@gmail.com

Date: Thu Sep 28 08:23:10 2023 +0900

1 file changed, 3 insertions(+), 3 deletions(-)
Successfully rebased and updated refs/heads/main.
ℹ  Add commit-queue-squash label to land the PR as one commit, or commit-queue-rebase to land as separate commits.

https://github.com/nodejs/node/actions/runs/6365784738

[nodejs-github-bot]

Landed in 092fb9f