tools: remove genv8constants.py #50023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unused after commit aa3a572 ("build: remove dtrace & etw support") from last year. I had this vague notion that llnode also used it but that is another script. Fixes: nodejs#49991
nodejs-github-bot
added
build
targos
approved these changes
Oct 3, 2023
anonrig
approved these changes
Oct 3, 2023
anonrig
added
author ready
github-actions
bot
removed
the
request-ci
benjamingr
approved these changes
Oct 3, 2023
richardlau
added
the
dont-land-on-v18.x
richardlau
approved these changes
Oct 3, 2023
tniessen
approved these changes
Oct 3, 2023
cjihrig
approved these changes
Oct 3, 2023
lpinca
approved these changes
Oct 3, 2023
bnoordhuis
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in f73650e |
alexfernandez
pushed a commit
to alexfernandez/node
that referenced
this pull request
Nov 1, 2023
Unused after commit aa3a572 ("build: remove dtrace & etw support") from last year. I had this vague notion that llnode also used it but that is another script. Fixes: nodejs#49991 PR-URL: nodejs#50023 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos
pushed a commit
that referenced
this pull request
Nov 11, 2023
Unused after commit aa3a572 ("build: remove dtrace & etw support") from last year. I had this vague notion that llnode also used it but that is another script. Fixes: #49991 PR-URL: #50023 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
debadree25
pushed a commit
to debadree25/node
that referenced
this pull request
Apr 15, 2024
Unused after commit aa3a572 ("build: remove dtrace & etw support") from last year. I had this vague notion that llnode also used it but that is another script. Fixes: nodejs#49991 PR-URL: nodejs#50023 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unused after commit aa3a572 ("build: remove dtrace & etw support") from last year. I had this vague notion that llnode also used it but that is another script.
Fixes: #49991