doc: use precise terminology in test runner #50028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We currently use `resolve` which is incorrect from a technical point of view in several places in the test runner docs. Most of the docs contain correct terminology. For anyone wondering "resolves" means the promise's fate is known by either settling (becoming fulfilled or rejected) or because it's assimilating the status of another promise (that may be unfulfilled).
benjamingr
added
doc
|
Review requested:
|
nodejs-github-bot
added
the
test_runner
benjamingr
added a commit
that referenced
this pull request
Oct 3, 2023
See #50028 for context - this also has the added benefit of reducing the amount of times we use resolving a promise vs resolving a path. Note this document already used `fulfills` in many cases and I kept resolves (for promises) in some cases where it made sense to me from a technical point of view
MoLow
approved these changes
Oct 3, 2023
|
@MoLow thanks, I pushed from GitHub directly since I'm OOO and without my box I'll fix it when I'm back. |
lpinca
approved these changes
Oct 3, 2023
atlowChemi
approved these changes
Oct 3, 2023
|
Landed in d3a5f1f |
aduh95
pushed a commit
that referenced
this pull request
Oct 8, 2023
See #50028 for context - this also has the added benefit of reducing the amount of times we use resolving a promise vs resolving a path. Note this document already used `fulfills` in many cases and I kept resolves (for promises) in some cases where it made sense to me from a technical point of view. PR-URL: #50029 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
alexfernandez
pushed a commit
to alexfernandez/node
that referenced
this pull request
Nov 1, 2023
We currently use `resolve` which is incorrect from a technical point of view in several places in the test runner docs. For anyone wondering "resolves" means the promise's fate is known by either settling (becoming fulfilled or rejected) or because it's assimilating the status of another promise (that may be unfulfilled). PR-URL: nodejs#50028 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
alexfernandez
pushed a commit
to alexfernandez/node
that referenced
this pull request
Nov 1, 2023
See nodejs#50028 for context - this also has the added benefit of reducing the amount of times we use resolving a promise vs resolving a path. Note this document already used `fulfills` in many cases and I kept resolves (for promises) in some cases where it made sense to me from a technical point of view. PR-URL: nodejs#50029 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
targos
pushed a commit
that referenced
this pull request
Nov 11, 2023
We currently use `resolve` which is incorrect from a technical point of view in several places in the test runner docs. For anyone wondering "resolves" means the promise's fate is known by either settling (becoming fulfilled or rejected) or because it's assimilating the status of another promise (that may be unfulfilled). PR-URL: #50028 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
targos
pushed a commit
that referenced
this pull request
Nov 11, 2023
See #50028 for context - this also has the added benefit of reducing the amount of times we use resolving a promise vs resolving a path. Note this document already used `fulfills` in many cases and I kept resolves (for promises) in some cases where it made sense to me from a technical point of view. PR-URL: #50029 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
debadree25
pushed a commit
to debadree25/node
that referenced
this pull request
Apr 15, 2024
We currently use `resolve` which is incorrect from a technical point of view in several places in the test runner docs. For anyone wondering "resolves" means the promise's fate is known by either settling (becoming fulfilled or rejected) or because it's assimilating the status of another promise (that may be unfulfilled). PR-URL: nodejs#50028 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
debadree25
pushed a commit
to debadree25/node
that referenced
this pull request
Apr 15, 2024
See nodejs#50028 for context - this also has the added benefit of reducing the amount of times we use resolving a promise vs resolving a path. Note this document already used `fulfills` in many cases and I kept resolves (for promises) in some cases where it made sense to me from a technical point of view. PR-URL: nodejs#50029 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently use
resolvewhich is incorrect from a technical point of view in several places in the test runner docs.Most of the docs contain correct terminology.
For anyone wondering "resolves" means the promise's fate is known by either settling (becoming fulfilled or rejected) or because it's assimilating the status of another promise (that may be unfulfilled).