Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: let deps require node prefixed modules #50047

Merged
merged 1 commit into from
Oct 6, 2023
Merged

lib: let deps require node prefixed modules #50047

merged 1 commit into from
Oct 6, 2023

Conversation

KhafraDev
Copy link
Member

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/loaders
  • @nodejs/startup

@nodejs-github-bot nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Oct 4, 2023
@KhafraDev KhafraDev changed the title lib: let deps require prefixed modules lib: let deps require node prefixed modules Oct 4, 2023
@KhafraDev
Copy link
Member Author

I'm not sure how to add a test for this.

aduh95
aduh95 approved these changes Oct 5, 2023
View reviewed changes
lib/internal/bootstrap/realm.js Outdated Show resolved Hide resolved
@targos
Copy link
Member

targos commented Oct 5, 2023

I'm not sure how to add a test for this.

IIUC, this will be covered with a future Undici update. I'm ok with that.

@panva panva added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Oct 5, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 5, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54557/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54561/

@panva panva added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 5, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 5, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54566/

Uzlopak
Uzlopak approved these changes Oct 5, 2023
View reviewed changes
Copy link
Contributor

@Uzlopak Uzlopak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54573/

@github-actions github-actions bot mentioned this pull request Oct 6, 2023
Open
10 tasks
@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 6, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 6, 2023
@nodejs-github-bot nodejs-github-bot merged commit 6b599a3 into nodejs:main Oct 6, 2023
54 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 6b599a3

@KhafraDev KhafraDev deleted the node-prefix-deps branch October 6, 2023 23:12
This was referenced Oct 7, 2023
Open
Open
Open
@RafaelGSS RafaelGSS mentioned this pull request Oct 9, 2023
Merged
@github-actions github-actions bot mentioned this pull request Oct 10, 2023
Open
24 tasks
alexfernandez pushed a commit to alexfernandez/node that referenced this pull request Nov 1, 2023
@KhafraDev @alexfernandez
lib: let deps require node prefixed modules
717fbbd 
fixup

fixup

PR-URL: nodejs#50047
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
debadree25 pushed a commit to debadree25/node that referenced this pull request Apr 15, 2024
@KhafraDev @debadree25
lib: let deps require node prefixed modules
8a6db3f 
fixup

fixup

PR-URL: nodejs#50047
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aduh95 aduh95 aduh95 approved these changes

@himself65 himself65 himself65 approved these changes

@Uzlopak Uzlopak Uzlopak approved these changes

@targos targos targos approved these changes

@lpinca lpinca lpinca approved these changes

@benjamingr benjamingr benjamingr approved these changes

@panva panva panva approved these changes

@Qard Qard Qard approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@KhafraDev @nodejs-github-bot @targos @Qard @panva @benjamingr @lpinca @Uzlopak @himself65 @aduh95