Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: reduce number of repetition in test-heapdump-shadowrealm.js #50104

Merged
merged 1 commit into from
Oct 12, 2023
Merged

test: reduce number of repetition in test-heapdump-shadowrealm.js #50104

merged 1 commit into from
Oct 12, 2023

Conversation

legendecas
Copy link
Member

ShadowRealm garbage-collection is covered in another test. Reduce the
number of repetition in test-heapdump-shadowrealm.js trying to fix the
flakiness of the test.

Refs: #49572

@legendecas
test: reduce number of repetition in test-heapdump-shadowrealm.js
ae716bc 
ShadowRealm garbage-collection is covered in another test. Reduce the
number of repetition in test-heapdump-shadowrealm.js trying to fix the
flakiness of the test.
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Oct 9, 2023
@lpinca lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 9, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 9, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54633/

@github-actions github-actions bot mentioned this pull request Oct 10, 2023
Open
24 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/54644/

@github-actions github-actions bot mentioned this pull request Oct 11, 2023
Open
30 tasks
@legendecas legendecas added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 12, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 12, 2023
@nodejs-github-bot nodejs-github-bot merged commit 224f3ae into nodejs:main Oct 12, 2023
32 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 224f3ae

@legendecas legendecas deleted the shadow-realm/fix-49572 branch October 12, 2023 09:36
@RafaelGSS RafaelGSS mentioned this pull request Oct 15, 2023
Merged
alexfernandez pushed a commit to alexfernandez/node that referenced this pull request Nov 1, 2023
@legendecas @alexfernandez
test: reduce number of repetition in test-heapdump-shadowrealm.js
8fba5c2 
ShadowRealm garbage-collection is covered in another test. Reduce the
number of repetition in test-heapdump-shadowrealm.js trying to fix the
flakiness of the test.

PR-URL: nodejs#50104
Refs: nodejs#49572
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
targos pushed a commit that referenced this pull request Nov 11, 2023
@legendecas @targos
test: reduce number of repetition in test-heapdump-shadowrealm.js
214997a 
ShadowRealm garbage-collection is covered in another test. Reduce the
number of repetition in test-heapdump-shadowrealm.js trying to fix the
flakiness of the test.

PR-URL: #50104
Refs: #49572
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
@targos targos mentioned this pull request Nov 12, 2023
Merged
@juanarbol juanarbol mentioned this pull request Dec 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anonrig anonrig anonrig approved these changes

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@legendecas @nodejs-github-bot @lpinca @anonrig