Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add EOVERFLOW as an allowed error #50128

Conversation

abmusse
Copy link
Contributor

@abmusse abmusse commented Oct 10, 2023

in test-fs-read-promises-position-validation.mjs

As stated in #50054

This looks like an oversight as
test-fs-read-position-validation.mjs includes
EOVERFLOW as an allowed error.

Fixes #50054

CC @nodejs/platform-ibmi

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Oct 10, 2023
in test-fs-read-promises-position-validation.mjs

As stated in nodejs#50054

This looks like an oversight as
test-fs-read-position-validation.mjs includes
EOVERFLOW as an allowed error.

Fixes nodejs#50054
@abmusse abmusse force-pushed the fix-parallel-test-fs-read-promises-position-validation branch from da380ab to a5f5257 Compare October 10, 2023 19:13
@richardlau richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 10, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 10, 2023
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@richardlau richardlau added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 11, 2023
@richardlau
Copy link
Member

https://ci.nodejs.org/job/node-test-commit-ibmi/1325/ shows the test now passes with this PR. The test-runner-cli-concurrency failure there will be addressed by #50108.

@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 12, 2023
@nodejs-github-bot nodejs-github-bot merged commit f0e720a into nodejs:main Oct 12, 2023
53 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in f0e720a

@abmusse abmusse deleted the fix-parallel-test-fs-read-promises-position-validation branch October 12, 2023 19:14
alexfernandez pushed a commit to alexfernandez/node that referenced this pull request Nov 1, 2023
in test-fs-read-promises-position-validation.mjs

As stated in nodejs#50054

This looks like an oversight as
test-fs-read-position-validation.mjs includes
EOVERFLOW as an allowed error.

Fixes nodejs#50054

PR-URL: nodejs#50128
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
@targos targos added dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. labels Nov 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test: parallel/test-fs-read-promises-position-validation fails on IBM i
6 participants