Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v18.x backport] https: fix connection checking interval not clearing on server close #50194

Closed
wants to merge 2 commits into from
Closed

[v18.x backport] https: fix connection checking interval not clearing on server close #50194

wants to merge 2 commits into from

Conversation

H4ad
Copy link
Member

@H4ad H4ad commented Oct 16, 2023 •
edited
Loading

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/crypto
  • @nodejs/http
  • @nodejs/net

@nodejs-github-bot nodejs-github-bot added http Issues or PRs related to the http subsystem. https Issues or PRs related to the https subsystem. needs-ci PRs that need a full CI run. v18.x Issues that can be reproduced on v18.x or PRs targeting the v18.x-staging branch. labels Oct 16, 2023
@Linkgoron @H4ad
https: fix connection checking interval not clearing on server close
4ad67a3 
The connection interval should close when httpsServer.close is called
similarly to how it gets cleared when httpServer.close is called.

fixes: nodejs#48373

Backport-PR-URL: nodejs#50194
@Linkgoron @H4ad
fixup! https: fix connection checking interval not clearing on server…
9399efb 
… close

Backport-PR-URL: nodejs#50194
@himself65
Copy link
Member

I don't know why node.js 18 has keep-alive for 5000ms by default. I think that shouldn't happen

@targos targos added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 26, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 26, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55938/

targos pushed a commit that referenced this pull request Nov 27, 2023
@Linkgoron @targos
https: fix connection checking interval not clearing on server close
2969722 
The connection interval should close when httpsServer.close is called
similarly to how it gets cleared when httpServer.close is called.

Fixes: #48373
PR-URL: #48383
Backport-PR-URL: #50194
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
@targos
Copy link
Member

targos commented Nov 27, 2023

Landed in 2969722

@targos targos closed this Nov 27, 2023
@H4ad H4ad deleted the backport-48383-to-18 branch December 2, 2023 23:57
@climba03003 climba03003 mentioned this pull request Feb 6, 2024
Closed
@Linkgoron Linkgoron mentioned this pull request Apr 2, 2024
Merged
kumarrishav added a commit to kumarrishav/node that referenced this pull request Apr 2, 2024
@kumarrishav
https: remove closeIdleConnections function while calling server close
37b3e06 
Correcting the nodejs#50194 backporting mistake. server.closeIdleConnections shouldn't be called while server.close in node v18. This behavior is for node v19 and above.

fixes: nodejs#52330, nodejs#51677,
@kumarrishav kumarrishav mentioned this pull request Apr 2, 2024
Closed
kumarrishav added a commit to kumarrishav/node that referenced this pull request Apr 2, 2024
@kumarrishav
https: remove closeIdleConnections function while calling server close
f59656c 
Correcting the nodejs#50194 backporting mistake.
closeIdleConnections shouldn't be called while server.close in node v18.
This behavior is for node v19 and above.

fixes: nodejs#52330, nodejs#51677,
kumarrishav added a commit to kumarrishav/node that referenced this pull request Apr 2, 2024
@kumarrishav
http: remove closeIdleConnections function while calling server close…
bc7c5c5 
….\n Correcting the nodejs#50194 backporting mistake.\n closeIdleConnections shouldnot be called while server.close in node v18.\n This behavior is for node v19 and above.\n fixes: nodejs#52330, nodejs#51677
@kumarrishav kumarrishav mentioned this pull request Apr 2, 2024
Closed
kumarrishav added a commit to kumarrishav/node that referenced this pull request Apr 2, 2024
@kumarrishav
http: remove closeIdleConnections function while calling server close.
bdb3b64 
Correcting the nodejs#50194 backporting mistake.
closeIdleConnections shouldnot be called while server.close in node v18.
This behavior is for node v19 and above.

fixes: nodejs#52330, nodejs#51677
@kumarrishav kumarrishav mentioned this pull request Apr 2, 2024
Closed
kumarrishav added a commit to kumarrishav/node that referenced this pull request Apr 2, 2024
@kumarrishav
http: remove closeIdleConnections function while calling server close.
eaa7de2 
Correcting the nodejs#50194 backporting mistake.
closeIdleConnections shouldnot be called while server.close in node v18.
This behavior is for node v19 and above.

fixes: nodejs#52330, nodejs#51677
kumarrishav added a commit to kumarrishav/node that referenced this pull request Apr 2, 2024
@kumarrishav
http: remove closeIdleConnections function while calling server close
1a435a9 
Correcting the nodejs#50194 backporting mistake.
closeIdleConnections shouldnot be called while server.close in node v18.
This behavior is for node v19 and above.

fixes: nodejs#52330, nodejs#51677
richardlau pushed a commit that referenced this pull request Apr 17, 2024
@kumarrishav @richardlau
http: remove closeIdleConnections function while calling server close
6689a98 
Correcting the #50194 backporting mistake.
closeIdleConnections shouldnot be called while server.close in node v18.
This behavior is for node v19 and above.

Fixes: #52330
Fixes: #51677
PR-URL: #52336
Refs: #50194
Reviewed-By: Nitzan Uziely <linkgoron@gmail.com>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
https: fix connection checking interval not clearing on
332ad91 
The connection interval should close when httpsServer.close is called
similarly to how it gets cleared when httpServer.close is called.

Fixes: nodejs/node#48373
PR-URL: nodejs/node#48383
Backport-PR-URL: nodejs/node#50194
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
https: fix connection checking interval not clearing on
f12e1c1 
The connection interval should close when httpsServer.close is called
similarly to how it gets cleared when httpServer.close is called.

Fixes: nodejs/node#48373
PR-URL: nodejs/node#48383
Backport-PR-URL: nodejs/node#50194
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@himself65 himself65 himself65 approved these changes

@anonrig anonrig anonrig approved these changes

Assignees
No one assigned
Labels
http Issues or PRs related to the http subsystem. https Issues or PRs related to the https subsystem. needs-ci PRs that need a full CI run. v18.x Issues that can be reproduced on v18.x or PRs targeting the v18.x-staging branch.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@H4ad @nodejs-github-bot @himself65 @targos @anonrig @Linkgoron