[v18.x backport] https: fix connection checking interval not clearing on server close #50194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
http
The connection interval should close when httpsServer.close is called similarly to how it gets cleared when httpServer.close is called. fixes: nodejs#48373 Backport-PR-URL: nodejs#50194
… close Backport-PR-URL: nodejs#50194
H4ad
force-pushed
the
backport-48383-to-18
branch
from
7168c73 to
9399efb
Compare
anonrig
approved these changes
Oct 16, 2023
himself65
approved these changes
Oct 16, 2023
|
I don't know why node.js 18 has keep-alive for 5000ms by default. I think that shouldn't happen |
github-actions
bot
removed
the
request-ci
targos
pushed a commit
that referenced
this pull request
Nov 27, 2023
The connection interval should close when httpsServer.close is called similarly to how it gets cleared when httpServer.close is called. Fixes: #48373 PR-URL: #48383 Backport-PR-URL: #50194 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
|
Landed in 2969722 |
kumarrishav
added a commit
to kumarrishav/node
that referenced
this pull request
Apr 2, 2024
Correcting the nodejs#50194 backporting mistake. server.closeIdleConnections shouldn't be called while server.close in node v18. This behavior is for node v19 and above. fixes: nodejs#52330, nodejs#51677,
kumarrishav
added a commit
to kumarrishav/node
that referenced
this pull request
Apr 2, 2024
Correcting the nodejs#50194 backporting mistake. closeIdleConnections shouldn't be called while server.close in node v18. This behavior is for node v19 and above. fixes: nodejs#52330, nodejs#51677,
kumarrishav
added a commit
to kumarrishav/node
that referenced
this pull request
Apr 2, 2024
….\n Correcting the nodejs#50194 backporting mistake.\n closeIdleConnections shouldnot be called while server.close in node v18.\n This behavior is for node v19 and above.\n fixes: nodejs#52330, nodejs#51677
kumarrishav
added a commit
to kumarrishav/node
that referenced
this pull request
Apr 2, 2024
Correcting the nodejs#50194 backporting mistake. closeIdleConnections shouldnot be called while server.close in node v18. This behavior is for node v19 and above. fixes: nodejs#52330, nodejs#51677
kumarrishav
added a commit
to kumarrishav/node
that referenced
this pull request
Apr 2, 2024
Correcting the nodejs#50194 backporting mistake. closeIdleConnections shouldnot be called while server.close in node v18. This behavior is for node v19 and above. fixes: nodejs#52330, nodejs#51677
kumarrishav
added a commit
to kumarrishav/node
that referenced
this pull request
Apr 2, 2024
Correcting the nodejs#50194 backporting mistake. closeIdleConnections shouldnot be called while server.close in node v18. This behavior is for node v19 and above. fixes: nodejs#52330, nodejs#51677
sercher
added a commit
to sercher/graaljs
that referenced
this pull request
Apr 25, 2024
The connection interval should close when httpsServer.close is called similarly to how it gets cleared when httpServer.close is called. Fixes: nodejs/node#48373 PR-URL: nodejs/node#48383 Backport-PR-URL: nodejs/node#50194 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
sercher
added a commit
to sercher/graaljs
that referenced
this pull request
Apr 25, 2024
The connection interval should close when httpsServer.close is called similarly to how it gets cleared when httpServer.close is called. Fixes: nodejs/node#48373 PR-URL: nodejs/node#48383 Backport-PR-URL: nodejs/node#50194 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #48383
Fixes #50188
Tasks: