Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stream: refactor writable _write #50198

Merged
merged 1 commit into from
Oct 24, 2023

Conversation

ronag
Copy link
Member

@ronag ronag commented Oct 16, 2023

Cleans up the implementation a bit to make future work easier.

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 16, 2023

Review requested:

  • @nodejs/streams

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Oct 16, 2023
@ronag ronag requested a review from mcollina October 16, 2023 13:35
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 17, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 17, 2023
@nodejs-github-bot
Copy link
Collaborator

ronag added a commit to nxtedition/node that referenced this pull request Oct 17, 2023
@@ -38,7 +38,7 @@ const GHI = new Uint8Array([0x47, 0x48, 0x49]);
assert(!(chunk instanceof Buffer));
assert(chunk instanceof Uint8Array);
assert.strictEqual(chunk, ABC);
assert.strictEqual(encoding, 'utf8');
assert.strictEqual(encoding, undefined);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mcollina wdyt?

@ronag ronag added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 17, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 17, 2023
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@ronag ronag added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 18, 2023
@nodejs-github-bot
Copy link
Collaborator

@ronag ronag added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 21, 2023
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Oct 21, 2023
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/50198
✔  Done loading data for nodejs/node/pull/50198
----------------------------------- PR info ------------------------------------
Title      stream: refactor writable _write (#50198)
Author     Robert Nagy  (@ronag)
Branch     ronag:writable-clean -> nodejs:main
Labels     author ready, needs-ci
Commits    1
 - stream: refactor writable _write
Committers 1
 - Robert Nagy 
PR-URL: https://github.com/nodejs/node/pull/50198
Reviewed-By: Yagiz Nizipli 
Reviewed-By: Marco Ippolito 
Reviewed-By: Matteo Collina 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/50198
Reviewed-By: Yagiz Nizipli 
Reviewed-By: Marco Ippolito 
Reviewed-By: Matteo Collina 
--------------------------------------------------------------------------------
   ⚠  Commits were pushed since the last approving review:
   ⚠  - stream: refactor writable _write
   ℹ  This PR was created on Mon, 16 Oct 2023 13:34:39 GMT
   ✔  Approvals: 3
   ✔  - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/50198#pullrequestreview-1680096270
   ✔  - Marco Ippolito (@marco-ippolito): https://github.com/nodejs/node/pull/50198#pullrequestreview-1680107397
   ✔  - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/50198#pullrequestreview-1681609596
   ✘  Last GitHub CI failed
   ℹ  Last Full PR CI on 2023-10-18T13:41:53Z: https://ci.nodejs.org/job/node-test-pull-request/54940/
- Querying data for job/node-test-pull-request/54940/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/6597965086

@aduh95
Copy link
Contributor

aduh95 commented Oct 23, 2023

@ronag can you please rebase to fix the git conflicts?

@ronag ronag added request-ci Add this label to start a Jenkins CI on a PR. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Oct 23, 2023
ronag added a commit to nxtedition/node that referenced this pull request Oct 23, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 23, 2023
ronag added a commit to nxtedition/node that referenced this pull request Oct 23, 2023
@ronag ronag added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 23, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 23, 2023
@nodejs-github-bot
Copy link
Collaborator

@ronag ronag added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 23, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 23, 2023
@nodejs-github-bot
Copy link
Collaborator

@ronag ronag added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 24, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 24, 2023
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/50198
✔  Done loading data for nodejs/node/pull/50198
----------------------------------- PR info ------------------------------------
Title      stream: refactor writable _write (#50198)
Author     Robert Nagy  (@ronag)
Branch     ronag:writable-clean -> nodejs:main
Labels     author ready, needs-ci
Commits    1
 - stream: refactor writable _write
Committers 1
 - Robert Nagy 
PR-URL: https://github.com/nodejs/node/pull/50198
Reviewed-By: Yagiz Nizipli 
Reviewed-By: Marco Ippolito 
Reviewed-By: Matteo Collina 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/50198
Reviewed-By: Yagiz Nizipli 
Reviewed-By: Marco Ippolito 
Reviewed-By: Matteo Collina 
--------------------------------------------------------------------------------
   ⚠  Commits were pushed since the last approving review:
   ⚠  - stream: refactor writable _write
   ℹ  This PR was created on Mon, 16 Oct 2023 13:34:39 GMT
   ✔  Approvals: 3
   ✔  - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/50198#pullrequestreview-1680096270
   ✔  - Marco Ippolito (@marco-ippolito): https://github.com/nodejs/node/pull/50198#pullrequestreview-1680107397
   ✔  - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/50198#pullrequestreview-1681609596
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2023-10-23T21:53:15Z: https://ci.nodejs.org/job/node-test-pull-request/55168/
- Querying data for job/node-test-pull-request/55168/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/6623263972

@nodejs-github-bot nodejs-github-bot added the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Oct 24, 2023
@ronag ronag requested a review from anonrig October 24, 2023 06:47
@anonrig anonrig added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Oct 24, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 24, 2023
@nodejs-github-bot nodejs-github-bot merged commit dbed031 into nodejs:main Oct 24, 2023
28 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in dbed031

alexfernandez pushed a commit to alexfernandez/node that referenced this pull request Nov 1, 2023
PR-URL: nodejs#50198
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
targos pushed a commit that referenced this pull request Nov 11, 2023
PR-URL: #50198
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
UlisesGascon pushed a commit that referenced this pull request Dec 11, 2023
PR-URL: #50198
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@UlisesGascon UlisesGascon mentioned this pull request Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants