Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: set test-http-regr-gh-2928 as flaky #50228

Closed

Conversation

anonrig
Copy link
Member

@anonrig anonrig commented Oct 18, 2023

Ref: #49564

@anonrig anonrig requested a review from jasnell October 18, 2023 01:05
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Oct 18, 2023
@anonrig anonrig force-pushed the set-test-http-regr-gh-2928-flaky branch from bbbf92b to 9c86662 Compare October 18, 2023 01:06
@anonrig anonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 18, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 18, 2023
@nodejs-github-bot
Copy link
Collaborator

@anonrig anonrig force-pushed the set-test-http-regr-gh-2928-flaky branch from 9c86662 to fbefa4b Compare October 18, 2023 01:53
@anonrig anonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 18, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 18, 2023
@nodejs-github-bot
Copy link
Collaborator

@lpinca
Copy link
Member

lpinca commented Oct 18, 2023

It is flaky only on Windows 2016, I wonder if there is something wrong on the test machine.

Copy link
Contributor

@StefanStojanovic StefanStojanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is flaky only on Windows 2016, I wonder if there is something wrong on the test machine.

I had my suspicions about the x86 build that was tested there, but couldn't reproduce locally. Regarding the machines, those are planned for removal soon, so we can check after that happens to see if it was only machines or something else. Until that happens, I'm OK with marking the test as flaky.

@lpinca
Copy link
Member

lpinca commented Oct 18, 2023

@richardlau is it possible to add the the Windows 2016 to the node-stress-single-test job? I want to try this patch

diff --git a/test/sequential/test-http-regr-gh-2928.js b/test/sequential/test-http-regr-gh-2928.js
index 25476e0453..f6a9e16032 100644
--- a/test/sequential/test-http-regr-gh-2928.js
+++ b/test/sequential/test-http-regr-gh-2928.js
@@ -8,6 +8,8 @@ const httpCommon = require('_http_common');
 const { HTTPParser } = require('_http_common');
 const net = require('net');
 
+httpCommon.parsers.max = 50;
+
 const COUNT = httpCommon.parsers.max + 1;
 
 const parsers = new Array(COUNT);

We might want to apply it regardless of whether it solves the issue or not. There is no reason to use 1000 parsers in the test.

@richardlau
Copy link
Member

@richardlau is it possible to add the the Windows 2016 to the node-stress-single-test job? I want to try this patch

The job already has win2016-vs2017 but since it has Visual Studio 2017 the job won't even schedule due to our versioning rules.

In the node-test-commit-windows-fanned job Node.js is compiled for Windows on one machine and then the binary is copied over to other machines (e.g. the win2016 machines) for testing. node-stress-single-test is set up to compile and run on the same machine. AFAICT all of the win2016 machines have vs2017 only.

@lpinca
Copy link
Member

lpinca commented Oct 18, 2023

I understand, thank you.

@anonrig anonrig added the fast-track PRs that do not need to wait for 48 hours to land. label Oct 18, 2023
@github-actions
Copy link
Contributor

Fast-track has been requested by @anonrig. Please 👍 to approve.

@lpinca
Copy link
Member

lpinca commented Oct 18, 2023

Can we try with #50240 before landing this?

lpinca added a commit to lpinca/node that referenced this pull request Oct 18, 2023
The maximum number of parses in the free list is set to 1000. However
the test does not need to use this maximum. Reduce it to 50.

Refs: nodejs#50228 (comment)
lpinca added a commit to lpinca/node that referenced this pull request Oct 18, 2023
The maximum number of parsers in the free list is set to 1000. However
the test does not need to use this maximum. Reduce it to 50.

Refs: nodejs#50228 (comment)
@anonrig anonrig added the flaky-test Issues and PRs related to the tests with unstable failures on the CI. label Oct 18, 2023
@anonrig anonrig closed this Oct 19, 2023
@anonrig anonrig deleted the set-test-http-regr-gh-2928-flaky branch October 19, 2023 16:42
nodejs-github-bot pushed a commit that referenced this pull request Oct 20, 2023
The maximum number of parsers in the free list is set to 1000. However
the test does not need to use this maximum. Reduce it to 50.

Refs: #50228 (comment)
PR-URL: #50240
Fixes: #49564
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
targos pushed a commit that referenced this pull request Oct 23, 2023
The maximum number of parsers in the free list is set to 1000. However
the test does not need to use this maximum. Reduce it to 50.

Refs: #50228 (comment)
PR-URL: #50240
Fixes: #49564
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
alexfernandez pushed a commit to alexfernandez/node that referenced this pull request Nov 1, 2023
The maximum number of parsers in the free list is set to 1000. However
the test does not need to use this maximum. Reduce it to 50.

Refs: nodejs#50228 (comment)
PR-URL: nodejs#50240
Fixes: nodejs#49564
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
targos pushed a commit that referenced this pull request Nov 11, 2023
The maximum number of parsers in the free list is set to 1000. However
the test does not need to use this maximum. Reduce it to 50.

Refs: #50228 (comment)
PR-URL: #50240
Fixes: #49564
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
richardlau pushed a commit that referenced this pull request Apr 17, 2024
The maximum number of parsers in the free list is set to 1000. However
the test does not need to use this maximum. Reduce it to 50.

Refs: #50228 (comment)
PR-URL: #50240
Backport-PR-URL: #52384
Fixes: #49564
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
abhishekumar-tyagi pushed a commit to abhishekumar-tyagi/node that referenced this pull request May 5, 2024
The maximum number of parsers in the free list is set to 1000. However
the test does not need to use this maximum. Reduce it to 50.

Refs: nodejs/node#50228 (comment)
PR-URL: nodejs/node#50240
Fixes: nodejs/node#49564
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fast-track PRs that do not need to wait for 48 hours to land. flaky-test Issues and PRs related to the tests with unstable failures on the CI. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants