Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v18.x backport] test: fix edge snapshot stack traces #50237

Closed
wants to merge 1 commit into from
Closed

[v18.x backport] test: fix edge snapshot stack traces #50237

wants to merge 1 commit into from

Conversation

codebytere
Copy link
Member

Backporting #49659 - it's affecting Electron in 18 and it'd help us a fair bit for this to land.

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. v18.x Issues that can be reproduced on v18.x or PRs targeting the v18.x-staging branch. labels Oct 18, 2023
@codebytere codebytere mentioned this pull request Oct 18, 2023
Merged
4 tasks
@GeoffreyBooth @codebytere
test: fix edge snapshot stack traces
fc6fe0f 
PR-URL: nodejs#49659
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
mcollina
mcollina approved these changes Oct 18, 2023
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codebytere codebytere added request-ci Add this label to start a Jenkins CI on a PR. and removed needs-ci PRs that need a full CI run. labels Nov 1, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 1, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55393/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55422/

This was referenced Nov 3, 2023
Open
Open
Open
Open
Open
Open
Open
@targos
Copy link
Member

targos commented Nov 12, 2023

Thanks, the commit is now part of #50669

@targos targos closed this Nov 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

@MoLow MoLow MoLow approved these changes

@GeoffreyBooth GeoffreyBooth Awaiting requested review from GeoffreyBooth

Assignees
No one assigned
Labels
test Issues and PRs related to the tests. v18.x Issues that can be reproduced on v18.x or PRs targeting the v18.x-staging branch.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@codebytere @nodejs-github-bot @targos @mcollina @MoLow @GeoffreyBooth