.eslintrc: enable es6's spread

[thefourtheye]

This came up in
#5020 (comment). This
patch basically enables spread option so that eslint will be happy.

[cjihrig]

LGTM, but do we need this if we aren't using it anywhere yet?

[thefourtheye]

Hmmm, that is true. But unless we enable, no code can use spread operator, right?

[cjihrig]

That's true, but in that case, we might as well just turn everything on. I think in future versions of ESLint we'll be able to just enable an entire language version.

[thefourtheye]

@cjihrig Fair enough. I included all the relevant es6 things from http://eslint.org/docs/user-guide/configuring.html#specifying-language-options. PTAL.

[thefourtheye]

Oh wait! There are linter errors now.

[thefourtheye]

Okay, fixed now. All because of the usage of 'use strict' in modules, when modules rule was enabled.

[silverwind]

LGTM pending CI.

CI: https://ci.nodejs.org/job/node-test-pull-request/1484/

[cjihrig]

LGTM

[targos]

LGTM

[targos]

Btw I just tried eslint 2 (which is still in beta) here: https://github.com/targos/node/commits/eslint-v2
The upgrade will be quite easy and we'll be able to replace this list with parserOptions: { ecmaVersion: 6 } in the config.

[jasnell]

LGTM

[jbergstroem]

LGTM

[Trott]

@cjihrig wrote:

That's true, but in that case, we might as well just turn everything on. I think in future versions of ESLint we'll be able to just enable an entire language version.

I think that day is here already. #5052

[cjihrig]

I was referring to the upcoming ecmaVersion that @targos mentioned, but just setting the env is fine too :-)

[thefourtheye]

Closing in favor of #5052