Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: explain how to disable navigator #50310

Merged
merged 1 commit into from
Oct 22, 2023

Conversation

GeoffreyBooth
Copy link
Member

Per #50269 (comment), this adds a note about how to delete the navigator global if necessary. This also sets the experimental status level.

@GeoffreyBooth GeoffreyBooth added doc Issues and PRs related to the documentations. experimental Issues and PRs related to experimental features. dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. labels Oct 20, 2023
@GeoffreyBooth GeoffreyBooth added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 21, 2023
@nodejs-github-bot
Copy link
Collaborator

@bnoordhuis
Copy link
Member

Landing should wait until a decision has been made on whether or not to keep navigator around (IOW, blocked on #50269.)

@GeoffreyBooth
Copy link
Member Author

Landing should wait until a decision has been made on whether or not to keep navigator

No. We can always land this and remove the API.

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@GeoffreyBooth GeoffreyBooth added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 21, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 22, 2023
@nodejs-github-bot nodejs-github-bot merged commit 25576b5 into nodejs:main Oct 22, 2023
60 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 25576b5

targos pushed a commit that referenced this pull request Oct 23, 2023
PR-URL: #50310
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
@ljharb
Copy link
Member

ljharb commented Oct 26, 2023

cc @nodejs/web-standards since we weren't given a chance to weigh in before node's docs recommended a decades-old bad practice.

@aduh95
Copy link
Contributor

aduh95 commented Oct 26, 2023

Another issue with this recommendation if that --import runs after --require, so if the issue happens in a script that's being preloaded, users are out of luck.

@GeoffreyBooth GeoffreyBooth deleted the navigator-note branch October 26, 2023 18:48
alexfernandez pushed a commit to alexfernandez/node that referenced this pull request Nov 1, 2023
PR-URL: nodejs#50310
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. experimental Issues and PRs related to experimental features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants