Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: update ada to 2.7.2 #50338

Merged
merged 1 commit into from
Oct 23, 2023
Merged

deps: update ada to 2.7.2 #50338

merged 1 commit into from
Oct 23, 2023

Conversation

nodejs-github-bot
Copy link
Collaborator

This is an automated update of ada to 2.7.2.

@nodejs-github-bot nodejs-github-bot added the dependencies Pull requests that update a dependency file. label Oct 23, 2023
@nodejs-github-bot
Copy link
Collaborator Author

nodejs-github-bot commented Oct 23, 2023

Review requested:

  • @nodejs/url

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Oct 23, 2023
@anonrig anonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 23, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 23, 2023
@nodejs-github-bot
Copy link
Collaborator Author

@anonrig anonrig added the fast-track PRs that do not need to wait for 48 hours to land. label Oct 23, 2023
@github-actions
Copy link
Contributor

Fast-track has been requested by @anonrig. Please 👍 to approve.

@anonrig anonrig added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 23, 2023
@anonrig
Copy link
Member

anonrig commented Oct 23, 2023

@nodejs/url @nodejs/tsc can you approve fast-track so that we can include this PR in latest 21 release?

@targos
Copy link
Member

targos commented Oct 23, 2023

Does it fix a known issue?

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@anonrig
Copy link
Member

anonrig commented Oct 23, 2023

Does it fix a known issue?

It fixes 2 bugs.

@anonrig anonrig added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 23, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 23, 2023
@nodejs-github-bot nodejs-github-bot merged commit 19216ab into main Oct 23, 2023
37 checks passed
@nodejs-github-bot nodejs-github-bot deleted the actions/tools-update-ada branch October 23, 2023 16:44
@nodejs-github-bot
Copy link
Collaborator Author

Landed in 19216ab

targos pushed a commit that referenced this pull request Oct 24, 2023
PR-URL: #50338
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
targos pushed a commit that referenced this pull request Oct 28, 2023
PR-URL: #50338
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
alexfernandez pushed a commit to alexfernandez/node that referenced this pull request Nov 1, 2023
PR-URL: nodejs#50338
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
targos pushed a commit that referenced this pull request Nov 11, 2023
PR-URL: #50338
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
PR-URL: nodejs/node#50338
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
PR-URL: nodejs/node#50338
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. dependencies Pull requests that update a dependency file. fast-track PRs that do not need to wait for 48 hours to land. needs-ci PRs that need a full CI run.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants