Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stream: readable use bitmap accessors #50350

Merged
merged 1 commit into from
Oct 25, 2023
Merged

stream: readable use bitmap accessors #50350

merged 1 commit into from
Oct 25, 2023

Conversation

ronag
Copy link
Member

@ronag ronag commented Oct 23, 2023 

streams/pipe-object-mode.js n=5000000         **      8.12 %       ±5.09% ±7.09% ±9.94%
streams/pipe.js n=5000000                             1.64 %       ±2.67% ±3.69% ±5.10%

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 23, 2023 •
edited by ronag
Loading

Review requested:

  • @nodejs/streams

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Oct 23, 2023
ronag added a commit to nxtedition/node that referenced this pull request Oct 23, 2023
@ronag
stream: Readable use bitmap accessors
87024e5 
PR-URL: nodejs#50350
@ronag ronag requested review from rluvaton and mcollina October 23, 2023 21:04
@rluvaton rluvaton added stream Issues and PRs related to the stream subsystem. performance Issues and PRs related to the performance of Node.js. needs-benchmark-ci PR that need a benchmark CI run. labels Oct 23, 2023
@ronag ronag added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 23, 2023
ronag added a commit to nxtedition/node that referenced this pull request Oct 23, 2023
@ronag
streams: Readable use bitmap accessors
d6e11dc 
PR-URL: nodejs#50350
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 23, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55165/

ronag added a commit to nxtedition/node that referenced this pull request Oct 24, 2023
@ronag
streams: readable use bitmap accessors
3544359 
PR-URL: nodejs#50350
@ronag ronag changed the title stream: Readable use bitmap accessors stream: readable use bitmap accessors Oct 24, 2023
@ronag ronag added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 24, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55172/

@ronag ronag added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 24, 2023
Uzlopak
Uzlopak approved these changes Oct 24, 2023
View reviewed changes
Copy link
Contributor

@Uzlopak Uzlopak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55176/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55189/

@github-actions github-actions bot mentioned this pull request Oct 25, 2023
Open
16 tasks
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Oct 25, 2023
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/50350
✔  Done loading data for nodejs/node/pull/50350
----------------------------------- PR info ------------------------------------
Title      stream: readable use bitmap accessors (#50350)
Author     Robert Nagy  (@ronag)
Branch     ronag:readable-bitmap -> nodejs:main
Labels     stream, performance, author ready, needs-ci, needs-benchmark-ci
Commits    1
 - stream: readable use bitmap accessors
Committers 1
 - Robert Nagy 
PR-URL: https://github.com/nodejs/node/pull/50350
Reviewed-By: Benjamin Gruenbaum 
Reviewed-By: Raz Luvaton 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/50350
Reviewed-By: Benjamin Gruenbaum 
Reviewed-By: Raz Luvaton 
--------------------------------------------------------------------------------
   ⚠  Commits were pushed since the last approving review:
   ⚠  - stream: readable use bitmap accessors
   ℹ  This PR was created on Mon, 23 Oct 2023 21:04:28 GMT
   ✔  Approvals: 2
   ✔  - Benjamin Gruenbaum (@benjamingr) (TSC): https://github.com/nodejs/node/pull/50350#pullrequestreview-1693524231
   ✔  - Raz Luvaton (@rluvaton): https://github.com/nodejs/node/pull/50350#pullrequestreview-1693525520
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2023-10-24T13:57:48Z: https://ci.nodejs.org/job/node-test-pull-request/55189/
- Querying data for job/node-test-pull-request/55189/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/6646200515

@rluvaton rluvaton added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Oct 25, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 25, 2023
@nodejs-github-bot nodejs-github-bot merged commit 31e0759 into nodejs:main Oct 25, 2023
31 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 31e0759

This was referenced Oct 26, 2023
Open
Open
Open
alexfernandez pushed a commit to alexfernandez/node that referenced this pull request Nov 1, 2023
@ronag @alexfernandez
stream: readable use bitmap accessors
4afa033 
PR-URL: nodejs#50350
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Raz Luvaton <rluvaton@gmail.com>
targos pushed a commit that referenced this pull request Nov 11, 2023
@ronag @targos
stream: readable use bitmap accessors
586ec48 
PR-URL: #50350
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Raz Luvaton <rluvaton@gmail.com>
@targos targos mentioned this pull request Nov 12, 2023
Merged
UlisesGascon pushed a commit that referenced this pull request Dec 11, 2023
@ronag @UlisesGascon
stream: readable use bitmap accessors
9d52430 
PR-URL: #50350
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Raz Luvaton <rluvaton@gmail.com>
@UlisesGascon UlisesGascon mentioned this pull request Dec 12, 2023
Merged
@dead-claudia dead-claudia mentioned this pull request Feb 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rluvaton rluvaton rluvaton approved these changes

@Uzlopak Uzlopak Uzlopak approved these changes

@benjamingr benjamingr benjamingr approved these changes

@mcollina mcollina Awaiting requested review from mcollina

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-benchmark-ci PR that need a benchmark CI run. needs-ci PRs that need a full CI run. performance Issues and PRs related to the performance of Node.js. stream Issues and PRs related to the stream subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ronag @nodejs-github-bot @benjamingr @Uzlopak @rluvaton