stream: use bit fields for construct/destroy #50408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
ronag
added a commit
to nxtedition/node
that referenced
this pull request
Oct 26, 2023
ronag
force-pushed
the
bitmap-constructor-destroy
branch
from
6a5c0d6 to
3bf4eaf
Compare
ronag
added a commit
to nxtedition/node
that referenced
this pull request
Oct 26, 2023
ronag
force-pushed
the
bitmap-constructor-destroy
branch
from
3bf4eaf to
02e3f43
Compare
ronag
added a commit
to nxtedition/node
that referenced
this pull request
Oct 26, 2023
ronag
force-pushed
the
bitmap-constructor-destroy
branch
from
02e3f43 to
74712a7
Compare
ronag
added
request-ci
github-actions
bot
removed
the
request-ci
rluvaton
approved these changes
Oct 26, 2023
Comment on lines
+26
to
+34
| const kObjectMode = 1 << 0; | ||
| const kErrorEmitted = 1 << 1; | ||
| const kAutoDestroy = 1 << 2; | ||
| const kEmitClose = 1 << 3; | ||
| const kDestroyed = 1 << 4; | ||
| const kClosed = 1 << 5; | ||
| const kCloseEmitted = 1 << 6; | ||
| const kErrored = 1 << 7; | ||
| const kConstructed = 1 << 8; |
There was a problem hiding this comment.
How can we enforce that readable/writable stream will not have a bit state with the same position?
ronag
added a commit
to nxtedition/node
that referenced
this pull request
Oct 26, 2023
ronag
force-pushed
the
bitmap-constructor-destroy
branch
from
74712a7 to
763eaa1
Compare
benjamingr
approved these changes
Oct 26, 2023
19 tasks
ronag
force-pushed
the
bitmap-constructor-destroy
branch
from
763eaa1 to
cea0fb4
Compare
github-actions
bot
removed
the
request-ci
|
@ronag If the motivation of this change is performance, can you share the benchmarks? |
|
There is a CI benchmark |
anonrig
approved these changes
Oct 27, 2023
ronag
added
the
commit-queue
22 tasks
nodejs-github-bot
removed
the
commit-queue
|
Landed in 4c3dde9 |
This was referenced Oct 29, 2023
alexfernandez
pushed a commit
to alexfernandez/node
that referenced
this pull request
Nov 1, 2023
PR-URL: nodejs#50408 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Raz Luvaton <rluvaton@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
targos
pushed a commit
that referenced
this pull request
Nov 11, 2023
PR-URL: #50408 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Raz Luvaton <rluvaton@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
UlisesGascon
pushed a commit
that referenced
this pull request
Dec 11, 2023
PR-URL: #50408 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Raz Luvaton <rluvaton@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.