lib: make event static properties non writable and configurable

[BenzeneAlcohol]

The idl definition for Event makes the properties constants, this means that they shouldn't be configurable. However, they were, and this commit fixes that.

Fixes: #50417

[BenzeneAlcohol]

making writable: false, makes it such that the user cannot even assign a value. Is that what we intend at the end?

[BenzeneAlcohol]

I've run the linter and fixed the errors, and also changed up stuff a bit.

Please review @KhafraDev

[H4ad]

@BenzeneAlcohol Can you please fix the issue on the first commit?

https://github.com/nodejs/node/actions/runs/6690083519/job/18190085079?pr=50425

But thanks for the PR, looks great!

[BenzeneAlcohol]

@BenzeneAlcohol Can you please fix the issue on the first commit?

https://github.com/nodejs/node/actions/runs/6690083519/job/18190085079?pr=50425

But thanks for the PR, looks great!

Done, thank you! :)

[BenzeneAlcohol]

The test for some reason runs on the old commit message?
Do I have to squash all the commits into one manually?

[BenzeneAlcohol]

Any changes I have to further make?

[H4ad]

You can squash everything, or you can rebase, but you need to change the commit message, both should work.

[BenzeneAlcohol]

Squashed into one commit.

[BenzeneAlcohol]

Ok, I have a very noob question.

But I do some small changes, and every time do I have to make the detailed commit message? Because sometimes the change I do is like removing a few lines (like I removed a few console lines) but then the commit message should contain details about the actual change in case it gets merged.

So do I just wait for approval, then rebase all changes to 1 commit message? And have normal commit messages, 1 liners till that one final rebased single commit.

[H4ad]

From what I know, only the first message will be used to create the commit description, so it's fine you keep the first commit with the message and then create other commits for minor fixes.

About all commits, I will later add a flag to squash everything, so all the commits will be released as just one commit.

[KhafraDev]

But I do some small changes, and every time do I have to make the detailed commit message? Because sometimes the change I do is like removing a few lines (like I removed a few console lines) but then the commit message should contain details about the actual change in case it gets merged.

I believe only the first commit must be detailed, because they typically get squashed automatically when merged.

Personally, I use git rebase -i HEAD~[number of commits] and then squash all the commits together into the first one, then git push -f. That way I only need to worry about a single commit.

[BenzeneAlcohol]

But I do some small changes, and every time do I have to make the detailed commit message? Because sometimes the change I do is like removing a few lines (like I removed a few console lines) but then the commit message should contain details about the actual change in case it gets merged.

I believe only the first commit must be detailed, because they typically get squashed automatically when merged.

Personally, I use git rebase -i HEAD~[number of commits] and then squash all the commits together into the first one, then git push -f. That way I only need to worry about a single commit.

Got it, thanks!

[BenzeneAlcohol]

From what I know, only the first message will be used to create the commit description, so it's fine you keep the first commit with the message and then create other commits for minor fixes.

About all commits, I will later add a flag to squash everything, so all the commits will be released as just one commit.

Alrighty!

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/55396/

[BenzeneAlcohol]

Does that failed pipeline for 4 checks indicate any changes I have to do or are they some flaky tests?

[MrJithil]

Its not because of your changes.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/55418/

[BenzeneAlcohol]

Ok, I've made the changes hopefully the pipeline runs successfully 👀

Please look into the pending comment too

Done

[MrJithil]

LGTM

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/55434/

[tniessen]

Is this semver-major or do we consider it a bug fix?

[H4ad]

I think it is a bug fix since people are not supposed to change/modify these properties.

But if we want to be cautious, a semver-minor can be applied.

Maybe run CITMG too?

[KhafraDev]

definitely a bug fix, I wouldn't consider it a major change. If someone relied on changing these properties, they were relying on a bug.

[BenzeneAlcohol]

definitely a bug fix, I wouldn't consider it a major change. If someone relied on changing these properties, they were relying on a bug.

Agreed. Does it need semver-minor?

[BenzeneAlcohol]

Does this need anything else before merging?

[BenzeneAlcohol]

@KhafraDev and @H4ad any blockers stopping this from merge?

[nodejs-github-bot]

Landed in b4850f2

[MrJithil]

@KhafraDev and @H4ad any blockers stopping this from merge?

IMO No. It's already landed