stream: remove no longer relevant comment #50446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ronag
force-pushed
the
transform-comment
branch
from
26f7e4c to
49d6dc9
Compare
|
Review requested:
|
benjamingr
approved these changes
Oct 28, 2023
benjamingr
added
the
fast-track
|
Fast-track has been requested by @benjamingr. Please 👍 to approve. |
anonrig
approved these changes
Oct 28, 2023
benjamingr
added
the
commit-queue
jasnell
approved these changes
Oct 28, 2023
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/50446 ✔ Done loading data for nodejs/node/pull/50446 ----------------------------------- PR info ------------------------------------ Title stream: remove no longer relevant comment (#50446) Author Robert Nagy (@ronag) Branch ronag:transform-comment -> nodejs:main Labels fast-track, needs-ci Commits 1 - stream: remove no longer relevant comment Committers 1 - Robert Nagy PR-URL: https://github.com/nodejs/node/pull/50446 Reviewed-By: Benjamin Gruenbaum Reviewed-By: Yagiz Nizipli Reviewed-By: James M Snell ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/50446 Reviewed-By: Benjamin Gruenbaum Reviewed-By: Yagiz Nizipli Reviewed-By: James M Snell -------------------------------------------------------------------------------- ℹ This PR was created on Sat, 28 Oct 2023 13:22:16 GMT ✔ Approvals: 3 ✔ - Benjamin Gruenbaum (@benjamingr) (TSC): https://github.com/nodejs/node/pull/50446#pullrequestreview-1702792357 ✔ - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/50446#pullrequestreview-1702794868 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/50446#pullrequestreview-1702808819 ℹ This PR is being fast-tracked ✔ Last GitHub CI successful ✘ No Jenkins CI runs detected -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/6678101104 |
benjamingr
added
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/50446 ✔ Done loading data for nodejs/node/pull/50446 ----------------------------------- PR info ------------------------------------ Title stream: remove no longer relevant comment (#50446) Author Robert Nagy (@ronag) Branch ronag:transform-comment -> nodejs:main Labels fast-track Commits 1 - stream: remove no longer relevant comment Committers 1 - Robert Nagy PR-URL: https://github.com/nodejs/node/pull/50446 Reviewed-By: Benjamin Gruenbaum Reviewed-By: Yagiz Nizipli Reviewed-By: James M Snell ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/50446 Reviewed-By: Benjamin Gruenbaum Reviewed-By: Yagiz Nizipli Reviewed-By: James M Snell -------------------------------------------------------------------------------- ℹ This PR was created on Sat, 28 Oct 2023 13:22:16 GMT ✔ Approvals: 3 ✔ - Benjamin Gruenbaum (@benjamingr) (TSC): https://github.com/nodejs/node/pull/50446#pullrequestreview-1702792357 ✔ - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/50446#pullrequestreview-1702794868 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/50446#pullrequestreview-1702808819 ℹ This PR is being fast-tracked ✔ Last GitHub CI successful ✘ No Jenkins CI runs detected -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/6678286873 |
lpinca
approved these changes
Oct 28, 2023
MoLow
added
request-ci
MoLow
approved these changes
Oct 28, 2023
github-actions
bot
removed
the
request-ci
VoltrexKeyva
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 12766fc |
alexfernandez
pushed a commit
to alexfernandez/node
that referenced
this pull request
Nov 1, 2023
Refs: nodejs#50014 PR-URL: nodejs#50446 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.