Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: relax version check with shared OpenSSL #50505

Merged
merged 1 commit into from
Nov 8, 2023
Merged

test: relax version check with shared OpenSSL #50505

merged 1 commit into from
Nov 8, 2023

Conversation

lpinca
Copy link
Member

@lpinca lpinca commented Nov 1, 2023

Relax the OpenSSL version check when Node.js is built with the --shared-openssl option. Verify only that process.versions.openssl is truthy.

Fixes: #43078

@lpinca
test: relax version check with shared OpenSSL
8738a7f 
Relax the OpenSSL version check when Node.js is built with the
`--shared-openssl` option. Verify only that `process.versions.openssl`
is truthy.

Fixes: nodejs#43078
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Nov 1, 2023
@lpinca lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 1, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 1, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55389/

@github-actions github-actions bot mentioned this pull request Nov 2, 2023
Open
25 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55406/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55417/

This was referenced Nov 3, 2023
Open
Open
Open
Open
Open
Open
@lpinca lpinca added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 8, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 8, 2023
@nodejs-github-bot nodejs-github-bot merged commit 3e3467e into nodejs:main Nov 8, 2023
32 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 3e3467e

@richardlau richardlau added lts-watch-v18.x PRs that may need to be released in v18.x. lts-watch-v20.x PRs that may need to be released in v20.x labels Nov 8, 2023
@lpinca lpinca deleted the relax/openssl-version-check branch November 8, 2023 20:59
targos pushed a commit that referenced this pull request Nov 11, 2023
@lpinca @targos
test: relax version check with shared OpenSSL
6005672 
Relax the OpenSSL version check when Node.js is built with the
`--shared-openssl` option. Verify only that `process.versions.openssl`
is truthy.

Fixes: #43078
PR-URL: #50505
Reviewed-By: Richard Lau <rlau@redhat.com>
@targos targos mentioned this pull request Nov 12, 2023
Merged
targos pushed a commit that referenced this pull request Nov 14, 2023
@lpinca @targos
test: relax version check with shared OpenSSL
931e1e7 
Relax the OpenSSL version check when Node.js is built with the
`--shared-openssl` option. Verify only that `process.versions.openssl`
is truthy.

Fixes: #43078
PR-URL: #50505
Reviewed-By: Richard Lau <rlau@redhat.com>
@targos targos added backported-to-v20.x PRs backported to the v20.x-staging branch. and removed lts-watch-v20.x PRs that may need to be released in v20.x labels Nov 15, 2023
targos pushed a commit that referenced this pull request Nov 15, 2023
@lpinca @targos
test: relax version check with shared OpenSSL
4e34f9a 
Relax the OpenSSL version check when Node.js is built with the
`--shared-openssl` option. Verify only that `process.versions.openssl`
is truthy.

Fixes: #43078
PR-URL: #50505
Reviewed-By: Richard Lau <rlau@redhat.com>
@targos targos removed the lts-watch-v18.x PRs that may need to be released in v18.x. label Nov 15, 2023
@targos targos added the backported-to-v18.x PRs backported to the v18.x-staging branch. label Nov 15, 2023
targos pushed a commit that referenced this pull request Nov 15, 2023
@lpinca @targos
test: relax version check with shared OpenSSL
8c918e5 
Relax the OpenSSL version check when Node.js is built with the
`--shared-openssl` option. Verify only that `process.versions.openssl`
is truthy.

Fixes: #43078
PR-URL: #50505
Reviewed-By: Richard Lau <rlau@redhat.com>
@targos targos mentioned this pull request Nov 21, 2023
Merged
@targos targos mentioned this pull request Nov 28, 2023
Merged
@juanarbol juanarbol mentioned this pull request Dec 6, 2023
Merged
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
test: relax version check with shared OpenSSL
2daf5a8 
Relax the OpenSSL version check when Node.js is built with the
`--shared-openssl` option. Verify only that `process.versions.openssl`
is truthy.

Fixes: nodejs/node#43078
PR-URL: nodejs/node#50505
Reviewed-By: Richard Lau <rlau@redhat.com>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
test: relax version check with shared OpenSSL
fb7058b 
Relax the OpenSSL version check when Node.js is built with the
`--shared-openssl` option. Verify only that `process.versions.openssl`
is truthy.

Fixes: nodejs/node#43078
PR-URL: nodejs/node#50505
Reviewed-By: Richard Lau <rlau@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlau richardlau richardlau approved these changes

Assignees
No one assigned
Labels
backported-to-v18.x PRs backported to the v18.x-staging branch. backported-to-v20.x PRs backported to the v20.x-staging branch. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FreeBSD openssl version string doesn't match regex test
4 participants
@lpinca @nodejs-github-bot @richardlau @targos