Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: remove unused file #50528

Merged
merged 1 commit into from
Nov 10, 2023
Merged

Conversation

jsumners
Copy link
Contributor

@jsumners jsumners commented Nov 2, 2023

This removes a source file that got re-added via a rebase. It seems somewhere around change set
178dff2 entry_point.c was removed, and rebase
0b6e16f added it back. The review of #48740 overlooked this and the file got re-committed.

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. node-api Issues and PRs related to the Node-API. test Issues and PRs related to the tests. labels Nov 2, 2023
@jsumners jsumners changed the title chore: remove unused file src: remove unused file Nov 2, 2023
Copy link
Contributor

@Uzlopak Uzlopak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@legendecas legendecas added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 3, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 3, 2023
@nodejs-github-bot
Copy link
Collaborator

Copy link
Member

@vmoroz vmoroz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@tniessen tniessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix before merging: the subsystem in the commit message is wrong. It should likely be test, not src.

@jsumners jsumners changed the title src: remove unused file test: remove unused file Nov 3, 2023
This removes a source file that got re-added via a rebase.
It seems somewhere around change set
nodejs@178dff2
`entry_point.c` was removed, and rebase
nodejs@0b6e16f
added it back. The review of nodejs#48740
overlooked this and the file got re-committed.
@tniessen tniessen added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 3, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 3, 2023
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@legendecas
Copy link
Member

legendecas commented Nov 10, 2023

https://ci.nodejs.org/job/node-test-commit-aix/48935/ was failing for node-api.test_worker_buffer_callback.test-free-called but I don't think it is related to this PR. Reliability report: https://github.com/nodejs/reliability/issues?q=is%3Aissue+is%3Aopen+test_worker_buffer_callback

@legendecas legendecas added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Nov 10, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 10, 2023
@nodejs-github-bot nodejs-github-bot merged commit 43f5b22 into nodejs:main Nov 10, 2023
32 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 43f5b22

@jsumners jsumners deleted the remove-unused-file branch November 10, 2023 17:23
targos pushed a commit that referenced this pull request Nov 11, 2023
This removes a source file that got re-added via a rebase.
It seems somewhere around change set
178dff2
`entry_point.c` was removed, and rebase
0b6e16f
added it back. The review of #48740
overlooked this and the file got re-committed.

PR-URL: #50528
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Vladimir Morozov <vmorozov@microsoft.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
targos pushed a commit that referenced this pull request Nov 14, 2023
This removes a source file that got re-added via a rebase.
It seems somewhere around change set
178dff2
`entry_point.c` was removed, and rebase
0b6e16f
added it back. The review of #48740
overlooked this and the file got re-committed.

PR-URL: #50528
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Vladimir Morozov <vmorozov@microsoft.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
UlisesGascon pushed a commit that referenced this pull request Dec 11, 2023
This removes a source file that got re-added via a rebase.
It seems somewhere around change set
178dff2
`entry_point.c` was removed, and rebase
0b6e16f
added it back. The review of #48740
overlooked this and the file got re-committed.

PR-URL: #50528
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Vladimir Morozov <vmorozov@microsoft.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@UlisesGascon UlisesGascon mentioned this pull request Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. node-api Issues and PRs related to the Node-API. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants