Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Replace forEach() with for ... of #50608

Closed
wants to merge 1 commit into from
Closed

test: Replace forEach() with for ... of #50608

wants to merge 1 commit into from

Conversation

alexweej
Copy link

@alexweej alexweej commented Nov 7, 2023

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Nov 7, 2023
@marco-ippolito marco-ippolito added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Nov 7, 2023
@tniessen
Copy link
Member

tniessen commented Nov 7, 2023

@alexweej Thank you for the contribution. Your commit email address does not appear to be associated with your GitHub account. We highly recommend fixing this, either by adding your commit email address to your GitHub account, or by re-committing using a different email address and force-pushing to the same branch (and PR).

Also, the commit message does not match the commit message guidelines. It needs to start with the prefix test:, followed by a space and an imperative verb. The length must not exceed 70 characters.

@alexweej
Copy link
Author

That'll teach me to use my work laptop...

@alexweej alexweej force-pushed the nodeconf-contrib-foreach branch from f019481 to f9fd61c Compare November 10, 2023 15:39
@alexweej alexweej changed the title Replace forEach() with for ... of in test-whatwg-encoding-custom-textdecoder-utf16-surrogates.js test: Replace forEach() with for ... of in test-whatwg-encoding-custom-textdecoder-utf16-surrogates.js Nov 10, 2023
@alexweej
Copy link
Author

@tniessen does the project prefer that we iterate on a single commit in each PR? As in, you need me to update both the PR title and the underlying commit title? Thanks again

@alexweej alexweej changed the title test: Replace forEach() with for ... of in test-whatwg-encoding-custom-textdecoder-utf16-surrogates.js test: Replace forEach() with for ... of Nov 10, 2023
@alexweej alexweej force-pushed the nodeconf-contrib-foreach branch from f9fd61c to 753aae0 Compare November 10, 2023 16:02
@jasnell jasnell added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 11, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 11, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55568/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55746/

@tniessen
Copy link
Member

does the project prefer that we iterate on a single commit in each PR? As in, you need me to update both the PR title and the underlying commit title? Thanks again

@alexweej We generally prefer pushing additional commits to update existing PRs, except when it comes to the commit message. The commit message of the first commit must adhere to the style guide, which is why that check is still failing on this PR. It is complaining that Replace is uppercase, so you need to change the commit message accordingly (test: replace...).

On a side note, neither the git commit author nor the committer are associated with your GitHub account. We recommend fixing this, but it is not required.

lpinca pushed a commit that referenced this pull request Dec 29, 2023
@lpinca
test: replace forEach() with for...of
55f3993 
Replace `Array.prototype.forEach()` with `for...of` in
`parallel/test-whatwg-encoding-custom-textdecoder-utf16-surrogates.js`.

PR-URL: #50608
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@lpinca
Copy link
Member

lpinca commented Dec 29, 2023

Landed in 55f3993.

@lpinca lpinca closed this Dec 29, 2023
RafaelGSS pushed a commit that referenced this pull request Jan 2, 2024
@RafaelGSS
test: replace forEach() with for...of
85ee2f7 
Replace `Array.prototype.forEach()` with `for...of` in
`parallel/test-whatwg-encoding-custom-textdecoder-utf16-surrogates.js`.

PR-URL: #50608
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@RafaelGSS RafaelGSS mentioned this pull request Jan 2, 2024
Merged
richardlau pushed a commit that referenced this pull request Mar 25, 2024
@richardlau
test: replace forEach() with for...of
9e41708 
Replace `Array.prototype.forEach()` with `for...of` in
`parallel/test-whatwg-encoding-custom-textdecoder-utf16-surrogates.js`.

PR-URL: #50608
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
richardlau pushed a commit that referenced this pull request Mar 25, 2024
@richardlau
test: replace forEach() with for...of
06a6eef 
Replace `Array.prototype.forEach()` with `for...of` in
`parallel/test-whatwg-encoding-custom-textdecoder-utf16-surrogates.js`.

PR-URL: #50608
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@richardlau richardlau mentioned this pull request Mar 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@alexweej @tniessen @nodejs-github-bot @lpinca @jasnell @marco-ippolito