Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Replace forEach() with for ... of in test-assert-typedarray-deepequal.js #50610

Closed
wants to merge 6 commits into from
Closed

test: Replace forEach() with for ... of in test-assert-typedarray-deepequal.js #50610

wants to merge 6 commits into from

Conversation

jialiu54321
Copy link
Contributor

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Nov 7, 2023
@tniessen
Copy link
Member

tniessen commented Nov 7, 2023

@jialiu54321 Thank you for the contribution. The commit message does not match the commit message guidelines. It needs to start with the prefix test:, followed by a space and an imperative lowercase verb. The length must not exceed 70 characters.

@tniessen tniessen added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Nov 7, 2023
@jialiu54321 jialiu54321 changed the title Replace forEach() with for ... of and use destructuring in test-assert-typedarray-deepequal.js test: Replace forEach() with for ... of in test-assert-typedarray-deepequal.js Nov 7, 2023
@lpinca lpinca added commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. request-ci Add this label to start a Jenkins CI on a PR. labels Dec 27, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 27, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56549/

@lpinca lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 27, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 27, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56566/

lpinca pushed a commit that referenced this pull request Dec 28, 2023
@jialiu54321 @lpinca
test: replace forEach() with for...of
4560834 
Replace `forEach()` with `for...of` in
`test/parallel/test-assert-typedarray-deepequal.js`.

PR-URL: #50610
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@lpinca
Copy link
Member

lpinca commented Dec 28, 2023

Landed in 4560834.

@lpinca lpinca closed this Dec 28, 2023
RafaelGSS pushed a commit that referenced this pull request Jan 2, 2024
@jialiu54321 @RafaelGSS
test: replace forEach() with for...of
652af45 
Replace `forEach()` with `for...of` in
`test/parallel/test-assert-typedarray-deepequal.js`.

PR-URL: #50610
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@RafaelGSS RafaelGSS mentioned this pull request Jan 2, 2024
Merged
richardlau pushed a commit that referenced this pull request Mar 25, 2024
@jialiu54321 @richardlau
test: replace forEach() with for...of
9474ff4 
Replace `forEach()` with `for...of` in
`test/parallel/test-assert-typedarray-deepequal.js`.

PR-URL: #50610
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
richardlau pushed a commit that referenced this pull request Mar 25, 2024
@jialiu54321 @richardlau
test: replace forEach() with for...of
42b162b 
Replace `forEach()` with `for...of` in
`test/parallel/test-assert-typedarray-deepequal.js`.

PR-URL: #50610
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@richardlau richardlau mentioned this pull request Mar 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jialiu54321 @tniessen @nodejs-github-bot @lpinca