Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: replace forEach with for...of #50611

Merged
merged 1 commit into from
Nov 12, 2023
Merged

test: replace forEach with for...of #50611

merged 1 commit into from
Nov 12, 2023

Conversation

SpaceDux
Copy link
Contributor

@SpaceDux SpaceDux commented Nov 7, 2023

No description provided.

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Nov 7, 2023
@tniessen
Copy link
Member

tniessen commented Nov 7, 2023

Thanks for the contribution @SpaceDux. Unfortunately, the commit message does not match our commit message guidelines. I'd suggest test: replace forEach with for...of or something similar. If you'd like, we can make this change for you by force-pushing to your branch.

@tniessen tniessen added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Nov 7, 2023
@SpaceDux SpaceDux changed the title test: Replace .forEach with for...const test: replace forEach with for...of Nov 7, 2023
@SpaceDux
Copy link
Contributor Author

SpaceDux commented Nov 7, 2023

Thanks for the contribution @SpaceDux. Unfortunately, the commit message does not match our commit message guidelines. I'd suggest test: replace forEach with for...of or something similar. If you'd like, we can make this change for you by force-pushing to your branch.

Thanks for the heads up. I have corrected the commit message now, hopefully its all good?.

tniessen
tniessen approved these changes Nov 8, 2023
View reviewed changes
Copy link
Member

@tniessen tniessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you @SpaceDux!

@tniessen tniessen added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Nov 8, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 8, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55500/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 11, 2023 •
edited by jasnell
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/55578/ 💛

@jasnell jasnell added commit-queue Add this label to land a pull request using GitHub Actions. and removed needs-ci PRs that need a full CI run. labels Nov 12, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 12, 2023
@nodejs-github-bot nodejs-github-bot merged commit 242cbd7 into nodejs:main Nov 12, 2023
42 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 242cbd7

targos pushed a commit that referenced this pull request Nov 23, 2023
@SpaceDux @targos
test: replace forEach with for...of
75265e4 
PR-URL: #50611
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@RafaelGSS RafaelGSS mentioned this pull request Nov 28, 2023
Merged
UlisesGascon pushed a commit that referenced this pull request Dec 11, 2023
@SpaceDux @UlisesGascon
test: replace forEach with for...of
4d28ced 
PR-URL: #50611
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@UlisesGascon UlisesGascon mentioned this pull request Dec 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tniessen tniessen tniessen approved these changes

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@SpaceDux @tniessen @nodejs-github-bot @lpinca @jasnell