Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: replace forEach with for [...] of #50615

Merged
merged 1 commit into from
Nov 10, 2023
Merged

test: replace forEach with for [...] of #50615

merged 1 commit into from
Nov 10, 2023

Conversation

dygabo
Copy link
Member

@dygabo dygabo commented Nov 7, 2023

NodeConf EU Workshop

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Nov 7, 2023
@dygabo dygabo force-pushed the nodeconf_workshop branch from 7b04414 to 30b1093 Compare November 8, 2023 06:33
tniessen
tniessen approved these changes Nov 8, 2023
View reviewed changes
Copy link
Member

@tniessen tniessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @dygabo!

@tniessen tniessen added code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Nov 8, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 8, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/55499/

@debadree25 debadree25 added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 10, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 10, 2023
@nodejs-github-bot nodejs-github-bot merged commit f662c9b into nodejs:main Nov 10, 2023
31 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in f662c9b

targos pushed a commit that referenced this pull request Nov 11, 2023
@dygabo @targos
test: replace forEach with for [...] of
924b331 
PR-URL: #50615
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
@targos targos mentioned this pull request Nov 12, 2023
Merged
targos pushed a commit that referenced this pull request Nov 14, 2023
@dygabo @targos
test: replace forEach with for [...] of
52b517f 
PR-URL: #50615
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
UlisesGascon pushed a commit that referenced this pull request Dec 11, 2023
@dygabo @UlisesGascon
test: replace forEach with for [...] of
ea61261 
PR-URL: #50615
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
@UlisesGascon UlisesGascon mentioned this pull request Dec 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@debadree25 debadree25 debadree25 approved these changes

@tniessen tniessen tniessen approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dygabo @nodejs-github-bot @tniessen @debadree25