doc: merging behavior of writeHead vs setHeader #5081
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It may also be worth noting this in the |
|
|
||
| ```js | ||
| // returns content-type = text/plain | ||
| const server = http.createServer( (req,res) => { |
There was a problem hiding this comment.
Can you remove the extra space between (s
There was a problem hiding this comment.
I looked over other code examples in the same file to maintain consistency and found:
[a0viedo@arya node]$ grep doc/api/http.markdown -r -e "((" | wc -l
0
[a0viedo@arya node]$ grep doc/api/http.markdown -r -e "( (" | wc -l
3
I don't have any context in which one is following the style, though.
There was a problem hiding this comment.
(( is what we would use in core.
|
LGTM, but @bengl's comment is worth addressing as well. |
|
LGTM. Landed in 3da7d13. |
silverwind
pushed a commit
that referenced
this pull request
Feb 9, 2016
PR-URL: #5081 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
rvagg
pushed a commit
that referenced
this pull request
Feb 10, 2016
PR-URL: #5081 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
MylesBorins
pushed a commit
that referenced
this pull request
Feb 22, 2016
PR-URL: #5081 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
MylesBorins
pushed a commit
that referenced
this pull request
Feb 22, 2016
PR-URL: #5081 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 2, 2016
PR-URL: #5081 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original contribution of @aredridel with some minor fixes discussed at #3895.
cc @nodejs/documentation