test: don't run test-tick-processor.js on Aix #5093
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM if CI is happy |
mscdex
added
the
lib / src
|
LGTM but "Aix" or "AIX"? Can you keep #5088 open so it's not forgotten about? |
|
LGTM |
|
@bnoordhuis will leave 5088 open and add reference to this one. In respect to "Aix" or "AIX" are you suggesting we change isAix to isAIX ? That might makes sense but is separate from this PR. |
Mostly just thinking out aloud. I was under the impression we use "AIX" in most places. |
|
Failure on CI should go away if you rebase against master again. Master was broken for a short time today and it looks like you caught it at the right moment. |
|
CI run looks good will land tomorrow. |
| // Currently the test-tick-processor functionality in V8 | ||
| // depends on addresses being smaller than a full 64 bits. Aix supports | ||
| // the full 64 bits and the result is that it does not process the | ||
| // addresses correctly and runs of out memory |
Currently the test-tick-processor functionality in V8 depends on addresses being smaller than a full 64 bits. Aix supports the full 64 bits and the result is that it does not process the addresses correctly and runs of out memory. Disabling until we get a fix upstreamed into V8.
|
Ok fixed typo and added TODO |
|
LGTM, though I also always thought it was AIX :-) |
|
On the AIX/Aix front you are quite possibly right, but unrelated to this PR as we'd have to fix other callers. I can do that as a separate PR we think its important enough |
mhdawson
added a commit
that referenced
this pull request
Feb 10, 2016
Currently the test-tick-processor functionality in V8 depends on addresses being smaller than a full 64 bits. Aix supports the full 64 bits and the result is that it does not process the addresses correctly and runs of out memory. Disabling until we get a fix upstreamed into V8. PR-URL: #5093 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: thefourtheye - Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
|
Landed as 97813be |
|
Test excluded in latest run closing |
rvagg
pushed a commit
that referenced
this pull request
Feb 15, 2016
Currently the test-tick-processor functionality in V8 depends on addresses being smaller than a full 64 bits. Aix supports the full 64 bits and the result is that it does not process the addresses correctly and runs of out memory. Disabling until we get a fix upstreamed into V8. PR-URL: #5093 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: thefourtheye - Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Feb 18, 2016
Currently the test-tick-processor functionality in V8 depends on addresses being smaller than a full 64 bits. Aix supports the full 64 bits and the result is that it does not process the addresses correctly and runs of out memory. Disabling until we get a fix upstreamed into V8. PR-URL: #5093 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: thefourtheye - Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Feb 18, 2016
Currently the test-tick-processor functionality in V8 depends on addresses being smaller than a full 64 bits. Aix supports the full 64 bits and the result is that it does not process the addresses correctly and runs of out memory. Disabling until we get a fix upstreamed into V8. PR-URL: #5093 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: thefourtheye - Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Mar 2, 2016
Currently the test-tick-processor functionality in V8 depends on addresses being smaller than a full 64 bits. Aix supports the full 64 bits and the result is that it does not process the addresses correctly and runs of out memory. Disabling until we get a fix upstreamed into V8. PR-URL: #5093 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: thefourtheye - Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the test-tick-processor functionality in V8
depends on addresses being smaller than a full 64 bits. Aix supports
the full 64 bits and the result is that it does not process the
addresses correctly and runs of out memory.
Disabling until we get a fix upstreamed into V8.