-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lib: refactor to use validateFunction in diagnostics_channel #50955
Merged
nodejs-github-bot
merged 1 commit into
nodejs:main
from
deokjinkim:231128_refactor_to_use_validatefunction
Nov 30, 2023
Merged
lib: refactor to use validateFunction in diagnostics_channel #50955
nodejs-github-bot
merged 1 commit into
nodejs:main
from
deokjinkim:231128_refactor_to_use_validatefunction
Nov 30, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use validateFunction to remove duplicate implementation.
nodejs-github-bot
added
diagnostics_channel
Issues and PRs related to diagnostics channel
needs-ci
PRs that need a full CI run.
labels
Nov 28, 2023
lpinca
approved these changes
Nov 28, 2023
deokjinkim
added
request-ci
Add this label to start a Jenkins CI on a PR.
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
labels
Nov 29, 2023
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
Nov 29, 2023
aduh95
approved these changes
Nov 29, 2023
aduh95
added
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Nov 29, 2023
JungMinu
approved these changes
Nov 29, 2023
nodejs-github-bot
removed
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Nov 30, 2023
Landed in e1bfd0a |
targos
pushed a commit
that referenced
this pull request
Dec 4, 2023
Use validateFunction to remove duplicate implementation. PR-URL: #50955 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
richardlau
pushed a commit
that referenced
this pull request
Mar 25, 2024
Use validateFunction to remove duplicate implementation. PR-URL: #50955 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
diagnostics_channel
Issues and PRs related to diagnostics channel
needs-ci
PRs that need a full CI run.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use validateFunction to remove duplicate implementation.