Skip to content

vm: use v8::DeserializeInternalFieldsCallback explicitly #50984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

vm: use v8::DeserializeInternalFieldsCallback explicitly #50984

wants to merge 2 commits into from

Conversation

@joyeecheung
Copy link
Member

@joyeecheung joyeecheung commented Nov 30, 2023

To avoid ambiguity in the signature.

This is necessary for the integration tests in https://chromium-review.googlesource.com/c/v8/v8/+/5074252 to pass which in turn unblocks #50983

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. vm Issues and PRs related to the vm subsystem. labels Nov 30, 2023
@joyeecheung joyeecheung added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 30, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 30, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 30, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/56022/

@joyeecheung joyeecheung added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 3, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 3, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 3, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/56054/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 5, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/56112/

@legendecas
Copy link
Member

legendecas commented Dec 11, 2023

I don't think "contextify" is a valid subsystem in the commit message. Maybe src is fine.

@joyeecheung
vm: use v8::DeserializeInternalFieldsCallback explicitly
5bd7871 
To avoid ambiguity in the signature.
@joyeecheung joyeecheung changed the title contextify: use v8::DeserializeInternalFieldsCallback explicitly vm: use v8::DeserializeInternalFieldsCallback explicitly Dec 11, 2023
@joyeecheung
Copy link
Member Author

joyeecheung commented Dec 11, 2023

Updated to use vm: in the commit message

@joyeecheung joyeecheung added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 11, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 11, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 11, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/56229/

@legendecas
Copy link
Member

legendecas commented Dec 11, 2023

Need to run format-cpp as well.

@joyeecheung
Copy link
Member Author

joyeecheung commented Dec 12, 2023

Ran format-cpp

@joyeecheung joyeecheung added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 12, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 12, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 12, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/56256/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 13, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/56261/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 13, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/56268/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 13, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/56280/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 13, 2023

CI: https://ci.nodejs.org/job/node-test-pull-request/56281/

joyeecheung added a commit that referenced this pull request Dec 14, 2023
@joyeecheung
vm: use v8::DeserializeInternalFieldsCallback explicitly
429ec83 
To avoid ambiguity in the signature.

PR-URL: #50984
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
@joyeecheung
Copy link
Member Author

joyeecheung commented Dec 14, 2023

Landed in 429ec83

RafaelGSS pushed a commit that referenced this pull request Dec 15, 2023
@joyeecheung @RafaelGSS
vm: use v8::DeserializeInternalFieldsCallback explicitly
e178a43 
To avoid ambiguity in the signature.

PR-URL: #50984
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
@RafaelGSS RafaelGSS mentioned this pull request Dec 15, 2023
Merged
richardlau pushed a commit that referenced this pull request Mar 25, 2024
@joyeecheung @richardlau
vm: use v8::DeserializeInternalFieldsCallback explicitly
07fc077 
To avoid ambiguity in the signature.

PR-URL: #50984
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
@richardlau richardlau mentioned this pull request Mar 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

@anonrig anonrig anonrig approved these changes

@tniessen tniessen tniessen approved these changes

@daeyeon daeyeon daeyeon approved these changes

@legendecas legendecas legendecas approved these changes

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. vm Issues and PRs related to the vm subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@joyeecheung @nodejs-github-bot @legendecas @jasnell @anonrig @tniessen @daeyeon