-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fs: update param in jsdoc for createReadStream
and createWriteStream
#51063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
fs
Issues and PRs related to the fs subsystem / file system.
needs-ci
PRs that need a full CI run.
labels
Dec 5, 2023
pluris
force-pushed
the
doc/fs_jsdoc_stream
branch
from
December 5, 2023 15:11
53ca555
to
addb49f
Compare
lpinca
approved these changes
Dec 5, 2023
rluvaton
approved these changes
Dec 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
rluvaton
added
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
request-ci
Add this label to start a Jenkins CI on a PR.
labels
Dec 5, 2023
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
Dec 5, 2023
marco-ippolito
approved these changes
Dec 6, 2023
deokjinkim
approved these changes
Dec 6, 2023
lpinca
added
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Dec 7, 2023
nodejs-github-bot
removed
the
commit-queue
Add this label to land a pull request using GitHub Actions.
label
Dec 7, 2023
Landed in 42b238e |
RafaelGSS
pushed a commit
that referenced
this pull request
Dec 15, 2023
PR-URL: #51063 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Raz Luvaton <rluvaton@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
Merged
richardlau
pushed a commit
that referenced
this pull request
Mar 25, 2024
PR-URL: #51063 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Raz Luvaton <rluvaton@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
fs
Issues and PRs related to the fs subsystem / file system.
needs-ci
PRs that need a full CI run.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I updated the jsdoc for
createWriteStream()
andcreateReadStream()
infs
for inconsistencies with the documentation.fs.createReadStream(path[, options])
Add
signal
node/doc/api/fs.md
Lines 2490 to 2504 in 1e31a01
fs.createWriteStream(path[, options])
Add
signal
andhighWaterMark
node/doc/api/fs.md
Lines 2622 to 2637 in 1e31a01