Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: improve localWindowSize event descriptions #51071

Closed
wants to merge 1 commit into from
Closed

doc: improve localWindowSize event descriptions #51071

wants to merge 1 commit into from

Conversation

DavyLandman
Copy link
Contributor

@DavyLandman DavyLandman commented Dec 6, 2023 •
edited
Loading

The documentation listed the wrong event to subscribe to when calling localWindowSize. Also properly point out the correct event for http2 clients.

Fixes: #51014
Refs: #38426

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/http
  • @nodejs/http2
  • @nodejs/net

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. http2 Issues or PRs related to the http2 subsystem. labels Dec 6, 2023
@DavyLandman
doc: improve localWindowSize event descriptions
c3aed19 
The documentation listed the wrong event to subscribe to when calling
`localWindowSize`. Also properly point out the correct event for http2
clients.

Fixes: #51014
Refs: #38426
@jasnell
Copy link
Member

jasnell commented Dec 23, 2023

Landed in f91ccf4

@jasnell jasnell closed this Dec 23, 2023
jasnell pushed a commit that referenced this pull request Dec 23, 2023
@DavyLandman @jasnell
doc: improve localWindowSize event descriptions
f91ccf4 
The documentation listed the wrong event to subscribe to when calling
`localWindowSize`. Also properly point out the correct event for http2
clients.

Fixes: #51014
Refs: #38426
PR-URL: #51071
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@DavyLandman DavyLandman deleted the docs/improve-http2-local-window-size branch December 23, 2023 19:43
RafaelGSS pushed a commit that referenced this pull request Jan 2, 2024
@DavyLandman @RafaelGSS
doc: improve localWindowSize event descriptions
8412751 
The documentation listed the wrong event to subscribe to when calling
`localWindowSize`. Also properly point out the correct event for http2
clients.

Fixes: #51014
Refs: #38426
PR-URL: #51071
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@RafaelGSS RafaelGSS mentioned this pull request Jan 2, 2024
Merged
richardlau pushed a commit that referenced this pull request Mar 25, 2024
@DavyLandman @richardlau
doc: improve localWindowSize event descriptions
01a4104 
The documentation listed the wrong event to subscribe to when calling
`localWindowSize`. Also properly point out the correct event for http2
clients.

Fixes: #51014
Refs: #38426
PR-URL: #51071
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@richardlau richardlau mentioned this pull request Mar 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aymen94 aymen94 aymen94 approved these changes

@lpinca lpinca lpinca approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. http2 Issues or PRs related to the http2 subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

http2 server receive speed is 20x slower than send speed
5 participants
@DavyLandman @nodejs-github-bot @jasnell @lpinca @aymen94