Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: update timezone to 2023c #51107

Closed
wants to merge 1 commit into from
Closed

deps: update timezone to 2023c #51107

wants to merge 1 commit into from

Conversation

nodejs-github-bot
Copy link
Collaborator

This PR was generated by tools/timezone-update.yml.

Updates the ICU files as per the instructions present in https://github.com/nodejs/node/blob/main/doc/contributing/maintaining/maintaining-icu.md#time-zone-data

To test, build node off this branch & log the version of tz using

console.log(process.versions.tz)

@nodejs-github-bot nodejs-github-bot added dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run. labels Dec 10, 2023
richardlau
richardlau requested changes Dec 10, 2023
View reviewed changes
Copy link
Member

@richardlau richardlau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This version of the timezone data is already in the version of ICU we are using. The automation script needs to be updated to prevent opening PRs in these cases.

@targos targos added the blocked PRs that are blocked by other issues or PRs. label Dec 10, 2023
@marco-ippolito marco-ippolito mentioned this pull request Dec 16, 2023
Merged
nodejs-github-bot pushed a commit that referenced this pull request Dec 20, 2023
@marco-ippolito
tools: check timezone current version
12fc7cb 
PR-URL: #51178
Refs: #51107
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
@targos targos closed this Dec 23, 2023
@targos targos deleted the actions/timezone-update branch December 23, 2023 10:26
RafaelGSS pushed a commit that referenced this pull request Jan 2, 2024
@marco-ippolito @RafaelGSS
tools: check timezone current version
3759491 
PR-URL: #51178
Refs: #51107
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
richardlau pushed a commit that referenced this pull request Mar 25, 2024
@marco-ippolito @richardlau
tools: check timezone current version
8e02d08 
PR-URL: #51178
Refs: #51107
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlau richardlau richardlau requested changes

Assignees
No one assigned
Labels
blocked PRs that are blocked by other issues or PRs. dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nodejs-github-bot @richardlau @targos