Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: update c-ares to 1.25.0 #51208

Closed
wants to merge 2 commits into from

Conversation

nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot nodejs-github-bot commented Dec 18, 2023

This is an automated update of c-ares to 1.25.0.

@nodejs-github-bot nodejs-github-bot added the dependencies Pull requests that update a dependency file. label Dec 18, 2023
@nodejs-github-bot
Copy link
Collaborator Author

Review requested:

  • @nodejs/net

@nodejs-github-bot nodejs-github-bot added cares Issues and PRs related to the c-ares dependency or the cares_wrap binding. needs-ci PRs that need a full CI run. labels Dec 18, 2023
@lpinca lpinca force-pushed the actions/tools-update-c-ares branch from 476b81e to 245caf3 Compare December 19, 2023 10:16
@lpinca lpinca force-pushed the actions/tools-update-c-ares branch from 245caf3 to 25d357b Compare December 19, 2023 10:27
@lpinca lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 19, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 19, 2023
@nodejs-github-bot
Copy link
Collaborator Author

@nodejs-github-bot
Copy link
Collaborator Author

@lpinca
Copy link
Member

lpinca commented Dec 19, 2023

@nodejs/platform-aix can you help? I tried to work around c-ares/c-ares#668 by adding #define HAVE_GETIFADDRS 1 and #define HAVE_IFADDRS_H 1 on unices but that does not work on AIX. Maybe it is easier to wait for the next c-ares release.

@richardlau
Copy link
Member

@nodejs/platform-aix can you help? I tried to work around c-ares/c-ares#668 by adding #define HAVE_GETIFADDRS 1 and #define HAVE_IFADDRS_H 1 on unices but that does not work on AIX. Maybe it is easier to wait for the next c-ares release.

AIX doesn't have ifaddrs.h so those defines should be 0 on AIX.

@lpinca
Copy link
Member

lpinca commented Dec 19, 2023

Yes, I understand, but I see no other way to work around the bug. I will remove the defines everywhere when the next c-ares release is cut.

@lpinca lpinca added the blocked PRs that are blocked by other issues or PRs. label Dec 19, 2023
@richardlau
Copy link
Member

Yes, I understand, but I see no other way to work around the bug. I will remove the defines everywhere when the next c-ares release is cut.

I think it makes sense to have those defines on platforms that have ifaddrs.h, just not on those that do not (e.g. AIX).

@lpinca
Copy link
Member

lpinca commented Dec 19, 2023

Ok, but I'm not sure if it is supported on all solaris versions. I think we should remove them there too.

@richardlau
Copy link
Member

Ok, but I'm not sure if it is supported on all solaris versions. I think we should remove them there too.

Well we have a team to ask re. that -- ping @nodejs/platform-smartos.

@nodejs-github-bot nodejs-github-bot changed the title deps: update c-ares to 1.24.0 deps: update c-ares to 1.25.0 Jan 5, 2024
@lpinca lpinca closed this Jan 5, 2024
@lpinca lpinca deleted the actions/tools-update-c-ares branch January 5, 2024 14:42
@lpinca
Copy link
Member

lpinca commented Jan 5, 2024

Closed in favor of #51385.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked PRs that are blocked by other issues or PRs. cares Issues and PRs related to the c-ares dependency or the cares_wrap binding. dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants