-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: update c-ares to 1.25.0 #51208
Conversation
Review requested:
|
476b81e
to
245caf3
Compare
245caf3
to
25d357b
Compare
@nodejs/platform-aix can you help? I tried to work around c-ares/c-ares#668 by adding |
AIX doesn't have |
Yes, I understand, but I see no other way to work around the bug. I will remove the defines everywhere when the next c-ares release is cut. |
I think it makes sense to have those defines on platforms that have |
Ok, but I'm not sure if it is supported on all solaris versions. I think we should remove them there too. |
Well we have a team to ask re. that -- ping @nodejs/platform-smartos. |
Closed in favor of #51385. |
This is an automated update of c-ares to 1.25.0.