lib: added isNativeError check to assert.js #51241
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added the function for compliance with frameworks such as Jest
nodejs-github-bot
added
assert
aduh95
reviewed
Dec 21, 2023
|
@aduh95 I would like to ask, the code is working fine normally, it starts having issues with frameworks like Jest. So what kinds of tests can be expected to be added? Till then I will undo the unrelated changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the function for compliance with
frameworks such as Jest
Fixes: #50780
I am not sure if what my eslint did is okay in the commit diff.
The actual changes are in lines 75, 424 and 425.