Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: eliminate duplicate code in histogram.cc #51263

Merged
merged 1 commit into from
Dec 25, 2023
Merged

src: eliminate duplicate code in histogram.cc #51263

merged 1 commit into from
Dec 25, 2023

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented Dec 23, 2023 •
edited
Loading

Could likely benefit from some fast-api implementations as well, but that can be done separately.

@jasnell jasnell requested a review from anonrig December 23, 2023 02:48
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Dec 23, 2023
@jasnell jasnell marked this pull request as draft December 23, 2023 02:49
@jasnell jasnell force-pushed the histogram-simplification branch from 050fa45 to 57fcfd2 Compare December 23, 2023 03:11
@jasnell jasnell marked this pull request as ready for review December 23, 2023 03:11
@jasnell jasnell added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 23, 2023
@jasnell jasnell requested a review from mcollina December 23, 2023 03:13
@jasnell jasnell force-pushed the histogram-simplification branch from 57fcfd2 to 5fbcc74 Compare December 23, 2023 03:15
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 23, 2023
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 23, 2023 •
edited by jasnell
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/56472/ 💛

@jasnell jasnell added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Dec 23, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 25, 2023
@nodejs-github-bot nodejs-github-bot merged commit a3a4eff into nodejs:main Dec 25, 2023
53 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in a3a4eff

RafaelGSS pushed a commit that referenced this pull request Jan 2, 2024
@jasnell @RafaelGSS
src: eliminate duplicate code in histogram.cc
df31c81 
PR-URL: #51263
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
@RafaelGSS RafaelGSS mentioned this pull request Jan 2, 2024
Merged
richardlau pushed a commit that referenced this pull request Mar 25, 2024
@jasnell @richardlau
src: eliminate duplicate code in histogram.cc
4ffdd37 
PR-URL: #51263
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
@richardlau richardlau mentioned this pull request Mar 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marco-ippolito marco-ippolito marco-ippolito approved these changes

@anonrig anonrig anonrig approved these changes

@mcollina mcollina Awaiting requested review from mcollina

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jasnell @nodejs-github-bot @anonrig @marco-ippolito