-
Notifications
You must be signed in to change notification settings - Fork 29.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lib: use deferred queue for all internal ticks calls #51279
Conversation
Review requested:
|
Might need to be |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a feeling this would be a significant negative impact on performance, but I would love to be proven wrong.
A couple of notes:
- I would keep _deferTick private, and not attached to process
- a CITGM run is necessary, but we would also need more modules in CITGM
What's your reasoning? Is the existing benchmark suite sufficient to prove you wrong? |
There is a lot more code in one of hottest functions of core |
The existing benchmarks would do, but we should check most of yhe affected subsystems. |
I second the request to make the |
Refs: #51267