Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib,src: remove detachArrayBuffer from buffer binding #51297

Closed
wants to merge 1 commit into from
Closed

lib,src: remove detachArrayBuffer from buffer binding #51297

wants to merge 1 commit into from

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented Dec 27, 2023

Now that ArrayBuffer.prototype.transfer is available, there's no need for the DetachArrayBuffer utility

@jasnell
lib,src: remove detachArrayBuffer from buffer binding
ee4a57a 
Now that `ArrayBuffer.prototype.transfer` is available, there's no
need for the `DetachArrayBuffer` utility
@nodejs-github-bot nodejs-github-bot added buffer Issues and PRs related to the buffer subsystem. c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. web streams labels Dec 27, 2023
@jasnell jasnell added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 27, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 27, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56563/

@anonrig
Copy link
Member

anonrig commented Dec 27, 2023

Duplicate of #50130

@anonrig anonrig marked this as a duplicate of #50130 Dec 27, 2023
@jasnell
Copy link
Member Author

jasnell commented Dec 27, 2023

oh ha! ok, closing in favor of that one

@jasnell jasnell closed this Dec 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tniessen tniessen Awaiting requested review from tniessen

@legendecas legendecas Awaiting requested review from legendecas

@aduh95 aduh95 Awaiting requested review from aduh95

Assignees
No one assigned
Labels
buffer Issues and PRs related to the buffer subsystem. c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. web streams
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jasnell @nodejs-github-bot @anonrig