-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
quic: various additional cleanups, fixes in Endpoint #51310
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review requested:
|
nodejs-github-bot
added
c++
Issues and PRs that require attention from people who are familiar with C++.
lib / src
Issues and PRs related to general changes in the lib or src directory.
needs-ci
PRs that need a full CI run.
labels
Dec 29, 2023
jasnell
force-pushed
the
quic-part-10
branch
from
December 29, 2023 15:52
d65779e
to
1ae7f4b
Compare
jasnell
added
the
quic
Issues and PRs related to the QUIC implementation / HTTP/3.
label
Dec 29, 2023
jasnell
force-pushed
the
quic-part-10
branch
from
December 29, 2023 17:57
1346705
to
78765b9
Compare
anonrig
approved these changes
Dec 29, 2023
jasnell
force-pushed
the
quic-part-10
branch
4 times, most recently
from
December 29, 2023 22:10
10c3f63
to
dee88f8
Compare
jasnell
force-pushed
the
quic-part-10
branch
from
December 29, 2023 23:21
dee88f8
to
b0f1863
Compare
This comment was marked as outdated.
This comment was marked as outdated.
jasnell
force-pushed
the
quic-part-10
branch
from
December 29, 2023 23:34
f92586c
to
f25e30b
Compare
This comment was marked as outdated.
This comment was marked as outdated.
jasnell
force-pushed
the
quic-part-10
branch
from
December 29, 2023 23:46
f25e30b
to
2f9b603
Compare
This comment was marked as outdated.
This comment was marked as outdated.
jasnell
force-pushed
the
quic-part-10
branch
from
December 29, 2023 23:48
2f9b603
to
84dbe6a
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Qard
reviewed
Dec 30, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did a quick skim and left some comments. Will have to find time for a more in-depth review another time.
jasnell
force-pushed
the
quic-part-10
branch
from
December 30, 2023 01:22
ec493df
to
615c63e
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
jasnell
force-pushed
the
quic-part-10
branch
from
December 30, 2023 18:35
8f68912
to
6d0b4c7
Compare
This comment was marked as outdated.
This comment was marked as outdated.
jasnell
added
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
and removed
needs-ci
PRs that need a full CI run.
labels
Jan 1, 2024
jasnell
added a commit
that referenced
this pull request
Jan 6, 2024
PR-URL: #51310 Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Landed in 3605574 |
marco-ippolito
pushed a commit
to marco-ippolito/node
that referenced
this pull request
Jan 12, 2024
PR-URL: nodejs#51310 Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Medhansh404
pushed a commit
to Medhansh404/node
that referenced
this pull request
Jan 19, 2024
PR-URL: nodejs#51310 Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
targos
pushed a commit
that referenced
this pull request
Feb 15, 2024
PR-URL: #51310 Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Merged
marco-ippolito
added
the
dont-land-on-v20.x
PRs that should not land on the v20.x-staging branch and should not be released in v20.x.
label
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
c++
Issues and PRs that require attention from people who are familiar with C++.
dont-land-on-v20.x
PRs that should not land on the v20.x-staging branch and should not be released in v20.x.
lib / src
Issues and PRs related to general changes in the lib or src directory.
quic
Issues and PRs related to the QUIC implementation / HTTP/3.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More incremental implementation of quic/http3
Adds debug logging details, starts to add the http3 internal impl