Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix flaky conditions for ppc64 SEA tests #51422

Merged
merged 1 commit into from
Jan 11, 2024
Merged

test: fix flaky conditions for ppc64 SEA tests #51422

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion test/sequential/sequential.status
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,9 @@ test-watch-mode-inspect: SKIP
# https://github.com/nodejs/node/issues/41286
test-performance-eventloopdelay: PASS, FLAKY

[$system==ppc || $system==ppc64]
[$system==linux && $arch==ppc64]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re. $arch and the confusion in the previous PR's -- it looks like this should match process.arch:

node/tools/test.py

Lines 1676 to 1688 in e0b159e

archEngineContext = Execute([vm, "-p", "process.arch"], context)
vmArch = archEngineContext.stdout.rstrip()
if archEngineContext.exit_code != 0 or vmArch == "undefined":
print("Can't determine the arch of: '%s'" % vm)
print(archEngineContext.stderr.rstrip())
continue
env = {
'mode': mode,
'system': utils.GuessOS(),
'arch': vmArch,
'type': get_env_type(vm, options.type, context),
'asan': get_asan_state(),
}

which on ppc64le is ppc64:

[iojs@test-osuosl-rhel8-ppc64--le-2 ~]$ ./build/workspace/node-test-commit-plinux/nodes/rhel8-ppc64le/out/Release/node -p process.arch
ppc64
[iojs@test-osuosl-rhel8-ppc64--le-2 ~]$

# https://github.com/nodejs/node/issues/50740
test-single-executable-application-disable-experimental-sea-warning: PASS, FLAKY
test-single-executable-application-empty: PASS, FLAKY
test-single-executable-application-snapshot-and-code-cache: PASS, FLAKY
test-single-executable-application-snapshot: PASS, FLAKY
Expand Down