-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: remove reference to resolved child_process v8 issue #51467
Conversation
The linked v8 issue is closed. The NodeJS half of that issue has also been resolved. While there still may be issues related to child_process spawn performance, they are not related to this v8 issue. Refs: https://bugs.chromium.org/p/v8/issues/detail?id=7381 Refs: nodejs#48523 Refs: nodejs/performance#138
I could remove the entire paragraph, as it was added all at once, but I figure the bit I've left is not wrong. Let me know if you think it should be removed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I missed this line! Can you delete the paragraph entirely? It's obviously true that any asynchronous operation will "perform[] memory operations synchronously", the previous wording made sense as a way of emphasizing a particularly large cost which I think is no longer necessary to mention.
Done. |
Commit Queue failed- Loading data for nodejs/node/pull/51467 ✔ Done loading data for nodejs/node/pull/51467 ----------------------------------- PR info ------------------------------------ Title doc: remove reference to resolved child_process v8 issue (#51467) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch isker:patch-2 -> nodejs:main Labels child_process, doc, author ready Commits 2 - doc: remove reference to resolved child_process v8 issue - Update child_process.md Committers 1 - GitHub PR-URL: https://github.com/nodejs/node/pull/51467 Refs: https://bugs.chromium.org/p/v8/issues/detail?id=7381 Refs: https://github.com/nodejs/node/pull/48523 Refs: https://github.com/nodejs/performance/issues/138 Reviewed-By: Keyhan Vakil Reviewed-By: Luigi Pinca ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/51467 Refs: https://bugs.chromium.org/p/v8/issues/detail?id=7381 Refs: https://github.com/nodejs/node/pull/48523 Refs: https://github.com/nodejs/performance/issues/138 Reviewed-By: Keyhan Vakil Reviewed-By: Luigi Pinca -------------------------------------------------------------------------------- ℹ This PR was created on Mon, 15 Jan 2024 03:47:37 GMT ✔ Approvals: 2 ✔ - Keyhan Vakil (@kvakil): https://github.com/nodejs/node/pull/51467#pullrequestreview-1826255104 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/51467#pullrequestreview-1828022124 ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 51467 From https://github.com/nodejs/node * branch refs/pull/51467/merge -> FETCH_HEAD ✔ Fetched commits as 6ab15a1aa8de..9cca93061688 -------------------------------------------------------------------------------- [main cfaf7262ca] doc: remove reference to resolved child_process v8 issue Author: Ian Kerins Date: Sun Jan 14 22:46:09 2024 -0500 1 file changed, 1 insertion(+), 3 deletions(-) [main b51f83b9b7] Update child_process.md Author: Ian Kerins Date: Wed Jan 17 01:44:46 2024 +0000 1 file changed, 4 deletions(-) ✔ Patches applied There are 2 commits in the PR. Attempting autorebase. Rebasing (2/4)https://github.com/nodejs/node/actions/runs/7560845377 |
Landed in eb4432c |
The linked v8 issue is closed. The NodeJS half of that issue has also been resolved. While there still may be issues related to child_process spawn performance, they are not related to this v8 issue. Refs: https://bugs.chromium.org/p/v8/issues/detail?id=7381 Refs: nodejs#48523 Refs: nodejs/performance#138 PR-URL: nodejs#51467 Reviewed-By: Keyhan Vakil <kvakil@sylph.kvakil.me> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
The linked v8 issue is closed. The NodeJS half of that issue has also been resolved. While there still may be issues related to child_process spawn performance, they are not related to this v8 issue. Refs: https://bugs.chromium.org/p/v8/issues/detail?id=7381 Refs: nodejs#48523 Refs: nodejs/performance#138 PR-URL: nodejs#51467 Reviewed-By: Keyhan Vakil <kvakil@sylph.kvakil.me> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
The linked v8 issue is closed. The NodeJS half of that issue has also been resolved. While there still may be issues related to child_process spawn performance, they are not related to this v8 issue. Refs: https://bugs.chromium.org/p/v8/issues/detail?id=7381 Refs: nodejs#48523 Refs: nodejs/performance#138 PR-URL: nodejs#51467 Reviewed-By: Keyhan Vakil <kvakil@sylph.kvakil.me> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
The linked v8 issue is closed. The NodeJS half of that issue has also been resolved. While there still may be issues related to child_process spawn performance, they are not related to this v8 issue. Refs: https://bugs.chromium.org/p/v8/issues/detail?id=7381 Refs: #48523 Refs: nodejs/performance#138 PR-URL: #51467 Reviewed-By: Keyhan Vakil <kvakil@sylph.kvakil.me> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
The linked v8 issue is closed. The NodeJS half of that issue has also been resolved. While there still may be issues related to child_process spawn performance, they are not related to this v8 issue. Refs: https://bugs.chromium.org/p/v8/issues/detail?id=7381 Refs: nodejs#48523 Refs: nodejs/performance#138 PR-URL: nodejs#51467 Reviewed-By: Keyhan Vakil <kvakil@sylph.kvakil.me> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
The linked v8 issue is closed. The NodeJS half of that issue has also been resolved. While there still may be issues related to child_process spawn performance, they are not related to this v8 issue. Refs: https://bugs.chromium.org/p/v8/issues/detail?id=7381 Refs: #48523 Refs: nodejs/performance#138 PR-URL: #51467 Reviewed-By: Keyhan Vakil <kvakil@sylph.kvakil.me> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
The linked v8 issue is closed. The NodeJS half of that issue has also been resolved. While there still may be issues related to child_process spawn performance, they are not related to this v8 issue. Refs: https://bugs.chromium.org/p/v8/issues/detail?id=7381 Refs: #48523 Refs: nodejs/performance#138 PR-URL: #51467 Reviewed-By: Keyhan Vakil <kvakil@sylph.kvakil.me> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
The linked v8 issue is closed. The NodeJS half of that issue has also been resolved. While there still may be issues related to child_process spawn performance, they are not related to this v8 issue.
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=7381
Refs: #48523
Refs: nodejs/performance#138