module: fix crash when built-in module export a default key
#51481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
lib / src
legendecas
approved these changes
Jan 16, 2024
|
Looking at this bug, it seems that assigning arbitrary keys to process.asdf = 'blah';
const processMod = await import('node:process');
console.log(processMod.asdf); // blahI would argue that this is still a bug even with this PR fix for the default crash. |
guybedford
approved these changes
Jan 16, 2024
GeoffreyBooth
approved these changes
Jan 16, 2024
Co-authored-by: Geoffrey Booth <webadmin@geoffreybooth.com>
aduh95
added
author ready
github-actions
bot
removed
the
request-ci
aymen94
approved these changes
Jan 16, 2024
debadree25
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/51481 ✔ Done loading data for nodejs/node/pull/51481 ----------------------------------- PR info ------------------------------------ Title module: fix crash when built-in module export a `default` key (#51481) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch aduh95:process-default -> nodejs:main Labels lib / src, author ready, needs-ci Commits 2 - module: fix crash when built-in module export a `default` key - Update lib/internal/bootstrap/realm.js Committers 2 - Antoine du Hamel - GitHub PR-URL: https://github.com/nodejs/node/pull/51481 Fixes: https://github.com/nodejs/node/issues/51480 Reviewed-By: Chengzhong Wu Reviewed-By: Guy Bedford Reviewed-By: Geoffrey Booth ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/51481 Fixes: https://github.com/nodejs/node/issues/51480 Reviewed-By: Chengzhong Wu Reviewed-By: Guy Bedford Reviewed-By: Geoffrey Booth -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last approving review: ⚠ - Update lib/internal/bootstrap/realm.js ℹ This PR was created on Tue, 16 Jan 2024 00:18:21 GMT ✔ Approvals: 3 ✔ - Chengzhong Wu (@legendecas) (TSC): https://github.com/nodejs/node/pull/51481#pullrequestreview-1822478224 ✔ - Guy Bedford (@guybedford): https://github.com/nodejs/node/pull/51481#pullrequestreview-1822522624 ✔ - Geoffrey Booth (@GeoffreyBooth) (TSC): https://github.com/nodejs/node/pull/51481#pullrequestreview-1822572122 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2024-01-16T17:44:01Z: https://ci.nodejs.org/job/node-test-pull-request/56816/ - Querying data for job/node-test-pull-request/56816/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/7580563296 |
legendecas
approved these changes
Jan 19, 2024
legendecas
added
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/51481 ✔ Done loading data for nodejs/node/pull/51481 ----------------------------------- PR info ------------------------------------ Title module: fix crash when built-in module export a `default` key (#51481) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch aduh95:process-default -> nodejs:main Labels lib / src, author ready, needs-ci Commits 2 - module: fix crash when built-in module export a `default` key - Update lib/internal/bootstrap/realm.js Committers 2 - Antoine du Hamel - GitHub PR-URL: https://github.com/nodejs/node/pull/51481 Fixes: https://github.com/nodejs/node/issues/51480 Reviewed-By: Chengzhong Wu Reviewed-By: Guy Bedford Reviewed-By: Geoffrey Booth ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/51481 Fixes: https://github.com/nodejs/node/issues/51480 Reviewed-By: Chengzhong Wu Reviewed-By: Guy Bedford Reviewed-By: Geoffrey Booth -------------------------------------------------------------------------------- ℹ This PR was created on Tue, 16 Jan 2024 00:18:21 GMT ✔ Approvals: 3 ✔ - Chengzhong Wu (@legendecas) (TSC): https://github.com/nodejs/node/pull/51481#pullrequestreview-1831785070 ✔ - Guy Bedford (@guybedford): https://github.com/nodejs/node/pull/51481#pullrequestreview-1822522624 ✔ - Geoffrey Booth (@GeoffreyBooth) (TSC): https://github.com/nodejs/node/pull/51481#pullrequestreview-1822572122 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2024-01-19T07:06:33Z: https://ci.nodejs.org/job/node-test-pull-request/56816/ - Querying data for job/node-test-pull-request/56816/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 51481 From https://github.com/nodejs/node * branch refs/pull/51481/merge -> FETCH_HEAD ✔ Fetched commits as eb4432c12c67..da6e2ca80b02 -------------------------------------------------------------------------------- [main d234630551] module: fix crash when built-in module export a `default` key Author: Antoine du Hamel Date: Tue Jan 16 01:17:29 2024 +0100 2 files changed, 10 insertions(+), 1 deletion(-) create mode 100644 test/parallel/test-process-default.js [main 3376c26fbc] Update lib/internal/bootstrap/realm.js Author: Antoine du Hamel Date: Tue Jan 16 10:35:42 2024 +0100 1 file changed, 2 insertions(+), 1 deletion(-) ✔ Patches applied There are 2 commits in the PR. Attempting autorebase. Rebasing (2/4)https://github.com/nodejs/node/actions/runs/7580926436 |
legendecas
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in a772973 |
Medhansh404
pushed a commit
to Medhansh404/node
that referenced
this pull request
Jan 19, 2024
PR-URL: nodejs#51481 Fixes: nodejs#51480 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
marco-ippolito
pushed a commit
to marco-ippolito/node
that referenced
this pull request
Jan 22, 2024
PR-URL: nodejs#51481 Fixes: nodejs#51480 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
marco-ippolito
pushed a commit
to marco-ippolito/node
that referenced
this pull request
Feb 2, 2024
PR-URL: nodejs#51481 Fixes: nodejs#51480 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
marco-ippolito
pushed a commit
to marco-ippolito/node
that referenced
this pull request
Feb 19, 2024
PR-URL: nodejs#51481 Fixes: nodejs#51480 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #51480