Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stream: always prefer reading first buffer #51500

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

stream: always prefer reading first buffer #51500

wants to merge 1 commit into from
+1 −4

Conversation

ronag
Copy link
Member

@ronag ronag commented Jan 17, 2024

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jan 17, 2024 •
edited by ronag
Loading

Review requested:

  • @nodejs/streams

@ronag ronag requested a review from mcollina January 17, 2024 17:15
@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Jan 17, 2024
@ronag
Copy link
Member Author

ronag commented Jan 17, 2024 •
edited
Loading

The old behavior doesn't make much sense to me... This is more efficient.

@mcollina
Copy link
Member

Can you add a test?

How much this is more efficient?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina Awaiting requested review from mcollina

Assignees
No one assigned
Labels
needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ronag @nodejs-github-bot @mcollina