Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: only run build-windows workflow on source changes #51596

Merged
merged 2 commits into from
Jan 31, 2024
Merged

tools: only run build-windows workflow on source changes #51596

merged 2 commits into from
Jan 31, 2024

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Jan 29, 2024

Since this workflow does not run any tests, it doesn't really makes sense to have it run on doc-only changes, or test-only changes.
I took inspiration for the list of paths from

node/.github/workflows/coverage-windows.yml

Lines 6 to 14 in 084d761

paths:
- lib/**/*.js
- Makefile
- src/**/*.cc
- src/**/*.h
- test/**
- tools/gyp/**
- tools/test.py
- .github/workflows/coverage-windows.yml

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/actions

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Jan 29, 2024
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Jan 29, 2024
aduh95
aduh95 commented Jan 29, 2024
View reviewed changes
.github/workflows/build-windows.yml Outdated Show resolved Hide resolved
.github/workflows/build-windows.yml Outdated Show resolved Hide resolved
@aduh95 aduh95 added the commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. label Jan 30, 2024
@richardlau
Copy link
Member

Since this workflow does not run any tests, it doesn't really makes sense to have it run on doc-only changes, or test-only changes.

FWIW there is an open issue on running the tests as well for Windows on the GitHub runners: #50489
(informational only, not a blocker for this PR)

@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 31, 2024
@nodejs-github-bot nodejs-github-bot merged commit 4ab63db into nodejs:main Jan 31, 2024
15 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 4ab63db

@aduh95 aduh95 deleted the build-windows-sometimes branch January 31, 2024 14:47
rdw-msft pushed a commit to rdw-msft/node that referenced this pull request Feb 9, 2024
@aduh95 @rdw-msft
tools: run build-windows workflow only on source changes
ec0c420 
PR-URL: nodejs#51596
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Tierney Cyren <hello@bnb.im>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
targos pushed a commit that referenced this pull request Feb 15, 2024
@aduh95 @targos
tools: run build-windows workflow only on source changes
5fe493d 
PR-URL: #51596
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Tierney Cyren <hello@bnb.im>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
marco-ippolito pushed a commit to marco-ippolito/node that referenced this pull request Feb 19, 2024
@aduh95 @marco-ippolito
tools: run build-windows workflow only on source changes
b653e32 
PR-URL: nodejs#51596
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Tierney Cyren <hello@bnb.im>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
@marco-ippolito marco-ippolito mentioned this pull request Mar 1, 2024
Merged
@targos
Copy link
Member

targos commented Mar 14, 2024

This prevents build-windows to run on build configuration changes (for example gyp file updates like #52083)

@targos
Copy link
Member

targos commented Mar 15, 2024

It also doesn't run when deps are updated: #51362

@richardlau
Copy link
Member

Those sound like good reasons to revert this.

richardlau pushed a commit that referenced this pull request Mar 25, 2024
@aduh95 @richardlau
tools: run build-windows workflow only on source changes
2c4c587 
PR-URL: #51596
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Tierney Cyren <hello@bnb.im>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
richardlau pushed a commit that referenced this pull request Mar 25, 2024
@aduh95 @richardlau
tools: run build-windows workflow only on source changes
0fb079b 
PR-URL: #51596
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Tierney Cyren <hello@bnb.im>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
@richardlau richardlau mentioned this pull request Mar 25, 2024
Merged
@targos targos mentioned this pull request Apr 2, 2024
Merged
nodejs-github-bot pushed a commit that referenced this pull request Apr 4, 2024
@targos
Revert "tools: run build-windows workflow only on source changes"
d7aa8fc 
This reverts commit 4ab63db.

PR-URL: #52320
Refs: #51596
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
marco-ippolito pushed a commit that referenced this pull request May 2, 2024
@targos @marco-ippolito
Revert "tools: run build-windows workflow only on source changes"
f06acc8 
This reverts commit 4ab63db.

PR-URL: #52320
Refs: #51596
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
marco-ippolito pushed a commit that referenced this pull request May 3, 2024
@targos @marco-ippolito
Revert "tools: run build-windows workflow only on source changes"
049cca4 
This reverts commit 4ab63db.

PR-URL: #52320
Refs: #51596
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marco-ippolito marco-ippolito marco-ippolito approved these changes

@StefanStojanovic StefanStojanovic StefanStojanovic approved these changes

@MoLow MoLow MoLow approved these changes

@anonrig anonrig anonrig approved these changes

@lpinca lpinca lpinca approved these changes

@bnb bnb bnb approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. meta Issues and PRs related to the general management of the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@aduh95 @nodejs-github-bot @richardlau @targos @bnb @lpinca @anonrig @MoLow @StefanStojanovic @marco-ippolito