Revert "test: try other ipv6 localhost alternatives" #5162
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 852313a. Conflicts: test/parallel/test-net-connect-options-ipv6.js
Fishrock123
added
net
|
Stress test for EDIT: I set that up wrong, here is the new stress test: https://ci.nodejs.org/job/node-stress-single-test/452/ |
|
It looks like the original issue still exists at least on |
|
Issue was fixed in ad36ea5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 852313a.
Edit: (Note: It is possible I resolved the conflicts incorrectly.)
See #4546 -- this test has 100% timeout rate on my OS X machine after said patch.
CI: https://ci.nodejs.org/job/node-test-pull-request/1609/
ping @mscdex