Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: use macOS m1 machines for testing #51620

Merged
merged 1 commit into from
Feb 2, 2024
Merged

build: use macOS m1 machines for testing #51620

merged 1 commit into from
Feb 2, 2024

Conversation

anonrig
Copy link
Member

@anonrig anonrig commented Jan 31, 2024 •
edited
Loading

macOS-14 now uses M1 machines. Let's see if the build speed and duration is worth the change.

Ref: https://github.blog/changelog/2024-01-30-github-actions-introducing-the-new-m1-macos-runner-available-to-open-source/

cc @nodejs/build

macOS-14: 27m
macOS-latest: 1h 18m

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/actions

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Jan 31, 2024
@richardlau
Copy link
Member

FWIW https://github.blog/changelog/2024-01-30-github-actions-macos-14-sonoma-is-now-available/ says that even if we were to stay on macos-latest, that will be switched to macOS 14 M1 later in the year.

@anonrig anonrig added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Jan 31, 2024
@aduh95
Copy link
Contributor

aduh95 commented Jan 31, 2024

macOS-14: 27m
macOS-latest: 1h 18m

That's the build time, worth noting the test time has also decreased with this PR (from 27min down to 16min), quite impressive. It makes me wonder if we should switch to macOS job to run tests faster on doc-only PRs (we probably should not, the number of macOS runners is way more limited than the number of linux ones)

mhdawson
mhdawson approved these changes Jan 31, 2024
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

UlisesGascon
UlisesGascon approved these changes Feb 1, 2024
View reviewed changes
Copy link
Member

@UlisesGascon UlisesGascon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

bnb
bnb approved these changes Feb 1, 2024
View reviewed changes
Copy link
Contributor

@bnb bnb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hell yeah

@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 2, 2024
@nodejs-github-bot nodejs-github-bot merged commit 6f85b13 into nodejs:main Feb 2, 2024
22 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 6f85b13

rdw-msft pushed a commit to rdw-msft/node that referenced this pull request Feb 9, 2024
@anonrig @rdw-msft
build: use macOS m1 machines for testing
1efdaf2 
PR-URL: nodejs#51620
Refs: https://github.blog/changelog/2024-01-30-github-actions-introducing-the-new-m1-macos-runner-available-to-open-source/
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Tierney Cyren <hello@bnb.im>
targos pushed a commit that referenced this pull request Feb 15, 2024
@anonrig @targos
build: use macOS m1 machines for testing
1999719 
PR-URL: #51620
Refs: https://github.blog/changelog/2024-01-30-github-actions-introducing-the-new-m1-macos-runner-available-to-open-source/
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Tierney Cyren <hello@bnb.im>
marco-ippolito pushed a commit to marco-ippolito/node that referenced this pull request Feb 19, 2024
@anonrig @marco-ippolito
build: use macOS m1 machines for testing
1aac9d9 
PR-URL: nodejs#51620
Refs: https://github.blog/changelog/2024-01-30-github-actions-introducing-the-new-m1-macos-runner-available-to-open-source/
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Tierney Cyren <hello@bnb.im>
@marco-ippolito marco-ippolito mentioned this pull request Mar 1, 2024
Merged
richardlau pushed a commit that referenced this pull request Mar 25, 2024
@anonrig @richardlau
build: use macOS m1 machines for testing
d10d97e 
PR-URL: #51620
Refs: https://github.blog/changelog/2024-01-30-github-actions-introducing-the-new-m1-macos-runner-available-to-open-source/
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Tierney Cyren <hello@bnb.im>
richardlau pushed a commit that referenced this pull request Mar 25, 2024
@anonrig @richardlau
build: use macOS m1 machines for testing
8e84aad 
PR-URL: #51620
Refs: https://github.blog/changelog/2024-01-30-github-actions-introducing-the-new-m1-macos-runner-available-to-open-source/
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Tierney Cyren <hello@bnb.im>
@richardlau richardlau mentioned this pull request Mar 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trivikr trivikr trivikr approved these changes

@aduh95 aduh95 aduh95 approved these changes

@mhdawson mhdawson mhdawson approved these changes

@richardlau richardlau richardlau approved these changes

@UlisesGascon UlisesGascon UlisesGascon approved these changes

@lpinca lpinca lpinca approved these changes

@bnb bnb bnb approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. meta Issues and PRs related to the general management of the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@anonrig @nodejs-github-bot @richardlau @aduh95 @bnb @lpinca @UlisesGascon @mhdawson @trivikr