doc: document the GN build #51676
Merged
doc: document the GN build #51676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
marco-ippolito
approved these changes
Feb 6, 2024
joyeecheung
reviewed
Feb 6, 2024
joyeecheung
approved these changes
Feb 7, 2024
aymen94
approved these changes
Feb 8, 2024
debadree25
approved these changes
Feb 8, 2024
debadree25
added
the
author ready
anonrig
approved these changes
Feb 9, 2024
anonrig
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
Commit Queue failed- Loading data for nodejs/node/pull/51676 ✔ Done loading data for nodejs/node/pull/51676 ----------------------------------- PR info ------------------------------------ Title doc: document the GN build (#51676) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch zcbenz:patch-16 -> nodejs:main Labels doc, author ready Commits 2 - doc: document the GN build - solve review comments Committers 1 - Cheng Zhao PR-URL: https://github.com/nodejs/node/pull/51676 Reviewed-By: Marco Ippolito Reviewed-By: Joyee Cheung Reviewed-By: Debadree Chatterjee Reviewed-By: Yagiz Nizipli ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/51676 Reviewed-By: Marco Ippolito Reviewed-By: Joyee Cheung Reviewed-By: Debadree Chatterjee Reviewed-By: Yagiz Nizipli -------------------------------------------------------------------------------- ℹ This PR was created on Tue, 06 Feb 2024 07:38:09 GMT ✔ Approvals: 4 ✔ - Marco Ippolito (@marco-ippolito): https://github.com/nodejs/node/pull/51676#pullrequestreview-1865129648 ✔ - Joyee Cheung (@joyeecheung) (TSC): https://github.com/nodejs/node/pull/51676#pullrequestreview-1868163517 ✔ - Debadree Chatterjee (@debadree25): https://github.com/nodejs/node/pull/51676#pullrequestreview-1870860955 ✔ - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/51676#pullrequestreview-1871583729 ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 51676 From https://github.com/nodejs/node * branch refs/pull/51676/merge -> FETCH_HEAD ✔ Fetched commits as 8a41d9b636be..9cc929bfe67c -------------------------------------------------------------------------------- [main 4c1504f6d6] doc: document the GN build Author: Cheng Zhao Date: Tue Feb 6 16:36:53 2024 +0900 1 file changed, 112 insertions(+) create mode 100644 doc/contributing/gn-build.md [main 160d3b3d4b] solve review comments Author: Cheng Zhao Date: Wed Feb 7 14:54:44 2024 +0900 1 file changed, 30 insertions(+), 17 deletions(-) ✔ Patches applied There are 2 commits in the PR. Attempting autorebase. Rebasing (2/4)https://github.com/nodejs/node/actions/runs/7839027752 |
nodejs-github-bot
added
the
commit-queue-failed
lpinca
approved these changes
Feb 9, 2024
UlisesGascon
approved these changes
Feb 10, 2024
debadree25
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 544cfc5 |
targos
pushed a commit
that referenced
this pull request
Feb 15, 2024
PR-URL: #51676 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Debadree Chatterjee <debadree333@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
rdw-msft
pushed a commit
to rdw-msft/node
that referenced
this pull request
Mar 20, 2024
PR-URL: nodejs#51676 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Debadree Chatterjee <debadree333@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
richardlau
pushed a commit
that referenced
this pull request
Mar 25, 2024
PR-URL: #51676 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Debadree Chatterjee <debadree333@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
richardlau
pushed a commit
that referenced
this pull request
Mar 25, 2024
PR-URL: #51676 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Debadree Chatterjee <debadree333@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.