-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v21.x backport] deps: update undici to 6.6.2 #51768
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review requested:
|
nodejs-github-bot
added
dependencies
Pull requests that update a dependency file.
needs-ci
PRs that need a full CI run.
v21.x
labels
Feb 15, 2024
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
Feb 15, 2024
RafaelGSS
approved these changes
Feb 15, 2024
marco-ippolito
approved these changes
Feb 16, 2024
I'll wait for #51792 to rebase. |
targos
force-pushed
the
undici-backport-v21
branch
from
February 20, 2024 05:16
376cc0e
to
c332fc0
Compare
Rebased. |
targos
force-pushed
the
undici-backport-v21
branch
from
February 20, 2024 05:18
c332fc0
to
57c0422
Compare
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
Feb 20, 2024
@targos can you rebase, the CI should fine fine now |
@marco-ippolito My branch is already up-to-date wrt. |
marco-ippolito
force-pushed
the
undici-backport-v21
branch
from
February 26, 2024 13:52
57c0422
to
c4c3396
Compare
marco-ippolito
force-pushed
the
v21.x-staging
branch
from
February 27, 2024 11:11
77872eb
to
a5a17a1
Compare
marco-ippolito
force-pushed
the
undici-backport-v21
branch
from
February 27, 2024 11:19
c4c3396
to
eb1a5b4
Compare
marco-ippolito
added
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
Feb 27, 2024
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
Feb 27, 2024
marco-ippolito
approved these changes
Feb 27, 2024
This reverts commit 95b1989. It appears that the workaround is still needed: issue nodejs#51081 Backport-PR-URL: nodejs#51390 PR-URL: nodejs#51390 Fixes: nodejs#51081 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
This commit is the result of reverting the v5.28.3 security update and then cleanly cherry-picking all 6.x updates from `main` until 6.6.2, which also includes the security fix.
marco-ippolito
force-pushed
the
undici-backport-v21
branch
from
February 28, 2024 13:04
eb1a5b4
to
d8a328f
Compare
marco-ippolito
added
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
Feb 28, 2024
github-actions
bot
removed
the
request-ci
Add this label to start a Jenkins CI on a PR.
label
Feb 28, 2024
marco-ippolito
approved these changes
Feb 29, 2024
marco-ippolito
force-pushed
the
v21.x-staging
branch
from
February 29, 2024 11:54
695be0f
to
e4d4bc6
Compare
Landed in 4ebb944 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit is the result of reverting the v5.28.3 security update
and then cleanly cherry-picking all 6.x updates from
main
until6.6.2, which also includes the security fix.
Reverts: 9d2ac2b
Includes: