-
Notifications
You must be signed in to change notification settings - Fork 30.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: clarify the restrictions of catching an uncaughtException #5180
Conversation
@nodejs/ctc ... thoughts? |
This might be worded better to simply say that if an exception is thrown from within an Also I'm not sure if it's really useful to suggest using something like |
Thanks for the clarification @mscdex ... I will revise my addition |
@NoahRoseLedesma Can you make sure to wrap lines at 80 columns while you're at it? |
I have revised the entry and wrapped the text in 06f07a6 |
LGTM |
LGTM. Should we give an example? |
LGTM, I'm -0 on an example. I wonder if |
I'd replace it with |
Yes, exit/terminate with a non-zero status code sounds much better. |
Alright, the latest commit changes the wording from die to exiting with a non zero exit code. |
PR-URL: #5180 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Benjamin Gruenbaum <inglor@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
Thanks! Landed in c605c5d with slight modification to the commit title to fit 52 chars. |
PR-URL: #5180 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Benjamin Gruenbaum <inglor@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
PR-URL: #5180 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Benjamin Gruenbaum <inglor@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
PR-URL: #5180 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Benjamin Gruenbaum <inglor@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
PR-URL: #5180 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Benjamin Gruenbaum <inglor@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
This commit adds information regarding catching uncaughtExceptions to the process doc. As brought up in #5147 the documentation does not state the recursion guard implemented in 2b252ac.